Skip to content

feat: UI/UX improvement#9

Merged
TarasKovalenko merged 2 commits into
mainfrom
Taras/ux-ui
Jun 11, 2026
Merged

feat: UI/UX improvement#9
TarasKovalenko merged 2 commits into
mainfrom
Taras/ux-ui

Conversation

@TarasKovalenko

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a unified toast notification system using a new useAppToast hook, adds tab count badges, and refactors the sidebar to display and filter vaults directly. It also improves accessibility with keyboard navigation on tables and cards, refines UI styling (such as a dedicated 'Danger zone' for purging secrets), and caps bulk deletion concurrency to prevent API throttling. The reviewer pointed out a React anti-pattern in Sidebar.tsx where the VaultRow component is defined inside the Sidebar component, which causes unnecessary unmounting/remounting and loss of keyboard focus during re-renders.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/components/layout/Sidebar.tsx Outdated
Defining VaultRow inside Sidebar created a new component type each
render, remounting the subtree and dropping keyboard focus during
filtering. Convert to renderVaultRow helper.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@TarasKovalenko TarasKovalenko merged commit 7e45867 into main Jun 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant