Failed Step Rollback#24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
This pull request introduces support for rollbacks in the step processing framework, allowing steps to define rollback functions that execute when a step fails. The changes include new types for rollback state and result, updates to the step execution logic to trigger rollbacks, and modifications to the context and step definitions to track rollback progress and arguments.
Rollback Functionality and Step Execution:
RollbackFunctionandRollbackArgsfields to theStepstruct, enabling steps to specify custom rollback logic and arguments.RollbackFntype and new types/constants forRollbackStateandRollbackResultto represent the outcome of rollback operations. [1] [2]Step Progress Tracking:
StepProgressstruct and context to include rollback results, and added a method to set rollback progress for a step. [1] [2]Example Usage and Refactoring:
example/main.goto demonstrate rollback usage, including a simulated failure and rollback function in the step definition. Also commented out unused code and steps for clarity. [1] [2] [3]Minor Fixes:
Let me know if you have any questions about how rollback is triggered or tracked in the new implementation!