Add pipeline/parent context to root execution span#257
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9225c67 to
34ce978
Compare
411831d to
df9765f
Compare
34ce978 to
30700b0
Compare
df9765f to
6feaf73
Compare
30700b0 to
5317505
Compare
6feaf73 to
c802f2b
Compare
5317505 to
68a527c
Compare
c802f2b to
e4ead67
Compare
68a527c to
7b0c735
Compare
e4ead67 to
015d113
Compare
7b0c735 to
93d7b73
Compare
015d113 to
c8b7609
Compare
93d7b73 to
798b90d
Compare
c8b7609 to
17209e2
Compare
798b90d to
573a81c
Compare
| if execution.parent_execution_id is not None: | ||
| attrs["execution.parent_id"] = execution.parent_execution_id | ||
| if execution.task_id_in_parent_execution is not None: | ||
| attrs["execution.task_id"] = execution.task_id_in_parent_execution |
There was a problem hiding this comment.
Is parent_id the upstream Node that the current execution node might be "WAITING_FOR_UPSTREAM" from?
Also,
if execution.task_id_in_parent_execution is not None:
attrs["execution.task_id"] = execution.task_id_in_parent_execution
wording is confusing for task_id_in_parent_execution, so is task_id going to be the current Node's ID or the parent's ID or something else?
There was a problem hiding this comment.
🤖 Good questions — clarifying both:
-
execution.parent_idis the ID of the parent graph/pipeline execution that spawned this child execution, not an upstream peer.WAITING_FOR_UPSTREAMrefers to waiting on sibling tasks within the same graph whose output artifacts feed in as inputs — those are peers, not the parent. -
execution.task_idhas been dropped from the span. The field name was confusing (it is the key this task has within the parent graph definition, e.g."train", not an execution ID), and we only want to surface attributes that are shown in the UI. We do surface execution IDs, but not this task key.execution.parent_idis kept.
17209e2 to
fc9dd0f
Compare
573a81c to
a4c0efb
Compare
execution.parent_id and execution.task_id link individual execution traces to their parent pipeline run, enabling correlation with future pipeline-level business logic traces.
a4c0efb to
c46efa4
Compare

Summary
execution.parent_idandexecution.task_idare now emitted on the root execution span when an execution belongs to a parent pipeline run. This links individual execution traces to their parent pipeline run, enabling correlation with future pipeline-level business logic traces.When
parent_execution_idortask_id_in_parent_executionare absent, the attributes are omitted from the span entirely.Screenshots