chore: v2 - ai assistant - unit tests#2336
Open
maxy-shpfy wants to merge 1 commit into
Open
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced May 28, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 28, 2026
maxy-shpfy
force-pushed
the
05-27-chore_v2_-_ai_assistant_-_unit_tests
branch
from
51f8b20 to
9c53fbc
Compare
maxy-shpfy
force-pushed
the
05-27-feat_v2_-_ai_assistant_-_architect_subagent
branch
from
a1a47ab to
87d63ae
Compare
maxy-shpfy
force-pushed
the
05-27-chore_v2_-_ai_assistant_-_unit_tests
branch
from
9c53fbc to
0405d6d
Compare
maxy-shpfy
force-pushed
the
05-27-feat_v2_-_ai_assistant_-_architect_subagent
branch
from
87d63ae to
860e741
Compare
maxy-shpfy
force-pushed
the
05-27-chore_v2_-_ai_assistant_-_unit_tests
branch
from
0405d6d to
8176a7b
Compare
maxy-shpfy
force-pushed
the
05-27-feat_v2_-_ai_assistant_-_architect_subagent
branch
from
860e741 to
d10347a
Compare
maxy-shpfy
force-pushed
the
05-27-chore_v2_-_ai_assistant_-_unit_tests
branch
from
8176a7b to
276e203
Compare
8 tasks
camielvs
approved these changes
Jun 1, 2026
Collaborator
camielvs
left a comment
camielvs
left a comment
There was a problem hiding this comment.
lgtm as long as tests continue to pass
maxy-shpfy
force-pushed
the
05-27-feat_v2_-_ai_assistant_-_architect_subagent
branch
from
d10347a to
76feab5
Compare
maxy-shpfy
force-pushed
the
05-27-chore_v2_-_ai_assistant_-_unit_tests
branch
2 times, most recently
from
98933d5 to
e65c099
Compare
maxy-shpfy
force-pushed
the
05-27-feat_v2_-_ai_assistant_-_architect_subagent
branch
2 times, most recently
from
cbf5a16 to
8e2e146
Compare
maxy-shpfy
force-pushed
the
05-27-chore_v2_-_ai_assistant_-_unit_tests
branch
from
e65c099 to
516b7d4
Compare
maxy-shpfy
force-pushed
the
05-27-feat_v2_-_ai_assistant_-_architect_subagent
branch
from
8e2e146 to
bbb8830
Compare
maxy-shpfy
force-pushed
the
05-27-chore_v2_-_ai_assistant_-_unit_tests
branch
from
516b7d4 to
f6e6941
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a comprehensive unit test suite covering the agent layer's core modules. The following areas are now tested:
SkillsLoader– cold-cache fetches, version-matched cache hits, stale-version refetches, offline fallback to stale IDB rows, 404 handling, and concurrent-call deduplication.createCsomTools– full 18-tool surface enumeration,get_pipeline_state/validate_pipelineJSON serialization,add_tasknull-field stripping and structured-outputs schema correctness (typedanyOfbranches), argument-order pins forrename_task,rename_input,rename_output, andset_task_argument, and null-to-undefined normalization foradd_input/add_output.createDebugTools– tool name enumeration and truncation wiring forget_execution_details(artifact-map collapse),get_container_state(debug_info key cap), andget_container_log(byte-budget enforcement).createRunTools– tool name enumeration andget_run_statusoverall-status derivation fromexecution_status_stats.executeSearchDocs– cosine-similarity ranking, defaulttopKof 5, empty-index short-circuit, IDB cache population and reuse, and fetch-failure error payload.executeSearchDocsis exported to enable direct testing.truncateutilities –truncateContainerLog(per-field byte budgets, null/undefined passthrough),truncateContainerState(20-key cap, per-value string truncation), andtruncateExecutionDetails(non-empty artifact map collapse).serializeSpecForAi– name/description, empty-spec defaults, input/output field inclusion, taskisSubgraphflag, binding serialization, andactiveSubgraphPathhandling.createToolBridge–requireSpecguard,getPipelineState, pipeline metadata mutations, task/input/output CRUD, connection creation/validation/deletion,setTaskArgument, subgraph creation, pipeline validation,submitPipelineRun(success, error, missing backend), anddebugPipelineRun(failed-child walking with truncated payloads).Test Instructions
All tests should pass with no failures.