Skip to content

Fix/postgres alias column autocomplete#267

Open
m-tonon wants to merge 3 commits into
TabularisDB:mainfrom
m-tonon:fix/postgres-alias-column-autocomplete
Open

Fix/postgres alias column autocomplete#267
m-tonon wants to merge 3 commits into
TabularisDB:mainfrom
m-tonon:fix/postgres-alias-column-autocomplete

Conversation

@m-tonon
Copy link
Copy Markdown
Contributor

@m-tonon m-tonon commented May 28, 2026

This PR implements a shared SQL autocomplete registration flow for both the editor and notebook views, improving lifecycle management and preventing stale or duplicate Monaco providers.

Changes:

  • Added useSqlAutocompleteRegistration hook to manage SQL autocomplete for active connections
  • Updated NotebookView to utilize the new hook, passing the effective schema and active state
  • Refactored Editor to replace direct SQL autocomplete registration with the hook
  • Introduced disposeSqlAutocomplete to clean up resources on connection changes, reconnect, and failures
  • Added support for schema-qualified table names, double-quoted identifiers, and alias resolution in PostgreSQL
  • Added regression tests for schema-qualified tables, quoted identifiers, and autocomplete disposal

Closes #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SQL autocomplete shows table names instead of columns after alias (PostgreSQL)

1 participant