-
-
Notifications
You must be signed in to change notification settings - Fork 160
Support for ssh authentication with security keys (like Yubikey) #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
475adfc
bd64d8e
c23c2e8
81164ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -217,6 +217,7 @@ export function SshConnectionsModal({ | |
| password: formData.password, | ||
| key_file: formData.key_file, | ||
| key_passphrase: formData.key_passphrase, | ||
| allow_passphrase_prompt: formData.allow_passphrase_prompt, | ||
| save_in_keychain: formData.save_in_keychain, | ||
| }; | ||
|
|
||
|
|
@@ -559,6 +560,24 @@ export function SshConnectionsModal({ | |
| </label> | ||
| </div> | ||
|
|
||
| <div className="flex items-center gap-2"> | ||
| <input | ||
| type="checkbox" | ||
| id="ssh-prompt-toggle" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. WARNING: Duplicate element ID |
||
| checked={!!formData.allow_passphrase_prompt} | ||
| onChange={(e) => { | ||
| updateField("allow_passphrase_prompt", e.target.checked); | ||
| }} | ||
| className="accent-blue-500 w-4 h-4 rounded cursor-pointer" | ||
| /> | ||
| <label | ||
| htmlFor="ssh-prompt-toggle" | ||
| className="text-sm font-medium text-secondary cursor-pointer select-none" | ||
| > | ||
| {t("newConnection.allowSshPrompt")} | ||
| </label> | ||
| </div> | ||
|
|
||
| {/* Test Button and Status */} | ||
| <div className="pt-4 border-t border-strong"> | ||
| <button | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Duplicate element ID
ssh-prompt-toggle. The same ID is also used inSshConnectionsModal.tsx. If both modals exist in the DOM simultaneously, clicking the<label htmlFor="ssh-prompt-toggle">will target the wrong checkbox, and it violates HTML uniqueness constraints. Consider prefixing the ID with a modal-specific identifier (e.g.,new-conn-ssh-prompt-toggle).