Skip to content

fix(freeze): prevent piston duplication around frozen blocks #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TWME-TW merged 1 commit into from
Jul 13, 2026
Merged

fix(freeze): prevent piston duplication around frozen blocks #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/main/java/dev/twme/debugstickpro/listeners/FreezeBlockIsolationListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,14 @@ public void onEntityExplode(EntityExplodeEvent event) {

@EventHandler(ignoreCancelled = true)
public void onBlockPistonExtend(BlockPistonExtendEvent event) {
if (isFrozenOrProtected(event.getBlock())
|| containsFrozenOrProtected(event.getBlocks())
|| containsFrozenOrProtectedAtDestination(event.getBlocks(), event.getDirection())) {
if (isPistonOperationBlocked(event.getBlock(), event.getDirection(), event.getBlocks(), event.getDirection())) {
event.setCancelled(true);
}
}

@EventHandler(ignoreCancelled = true)
public void onBlockPistonRetract(BlockPistonRetractEvent event) {
if (isFrozenOrProtected(event.getBlock())
|| containsFrozenOrProtected(event.getBlocks())
|| containsFrozenOrProtectedAtDestination(event.getBlocks(), event.getDirection().getOppositeFace())) {
if (isPistonOperationBlocked(event.getBlock(), event.getDirection(), event.getBlocks(), event.getDirection().getOppositeFace())) {
event.setCancelled(true);
}
}
Expand Down Expand Up @@ -139,6 +135,18 @@ private static boolean containsFrozenOrProtectedAtDestination(Iterable<Block> bl
return false;
}

private static boolean isPistonOperationBlocked(Block piston, BlockFace direction,
Iterable<Block> blocks, BlockFace destinationDirection) {
// A piston event can have an empty block list when the piston head or the
// adjacent block is not movable. Check those positions explicitly so a
// frozen piston assembly cannot still complete a pending movement.
return isFrozenOrProtected(piston)
|| isFrozenOrProtected(piston.getRelative(direction))
|| isFrozenOrProtected(piston.getRelative(direction, 2))
|| containsFrozenOrProtected(blocks)
|| containsFrozenOrProtectedAtDestination(blocks, destinationDirection);
}

private static boolean isFrozenOrProtected(Block block) {
return isFrozen(block) || isProtected(block);
}
Expand Down