菜单栏无内容时保持空白 - #20
Merged
Merged
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — single commit replacing the "Loading..." placeholder with a blank empty state when users close all menu bar display items.
- Replace placeholder text —
TickerRenderer.render(items:)returnsNSAttributedString()instead of the localized"ticker.empty"string when items are empty. - Reserve minimal click target —
TickerView,CarouselTickerView, andCompactTickerViewall return 24px fromtotalWidthwhen content is empty, preserving a small hit area for the status item without displaying any text. - Trim stale reserved width —
TickerView.update(attributed:)resetsvisibleTextWidthto 0 when the string is empty, preventing a false 280px text region from persisting in the layout. - Show zero-value assets —
CompactTickerView.renderPieces()no longer skipstotalAssetswhen the value is exactly 0, consistent with the user's toggle preference.
DeepSeek Flash | 𝕏
Owner
|
@1254455745 多谢拆分提交!这个 PR 目前和 |
1254455745
force-pushed
the
review/empty-menu-state-v2
branch
from
June 4, 2026 14:52
5905e70 to
3eb8b0b
Compare
Contributor
Author
|
重新提交啦,你看看~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

这个 PR 调整菜单栏无内容时的展示逻辑。
改动内容:
验证: