Skip to content

菜单栏无内容时保持空白 - #20

Merged
TNT-Likely merged 1 commit into
TNT-Likely:mainfrom
1254455745:review/empty-menu-state-v2
Jun 5, 2026
Merged

菜单栏无内容时保持空白#20
TNT-Likely merged 1 commit into
TNT-Likely:mainfrom
1254455745:review/empty-menu-state-v2

Conversation

@1254455745

Copy link
Copy Markdown
Contributor

这个 PR 调整菜单栏无内容时的展示逻辑。

改动内容:

  • 当用户关闭所有菜单栏内容时,不再显示“加载中”。
  • 空内容保持空白,符合用户主动关闭显示项的预期。
  • 调整滚动、轮播、固定相关视图的空内容宽度处理。

验证:

  • 单独分支构建通过。

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — single commit replacing the "Loading..." placeholder with a blank empty state when users close all menu bar display items.

  • Replace placeholder textTickerRenderer.render(items:) returns NSAttributedString() instead of the localized "ticker.empty" string when items are empty.
  • Reserve minimal click targetTickerView, CarouselTickerView, and CompactTickerView all return 24px from totalWidth when content is empty, preserving a small hit area for the status item without displaying any text.
  • Trim stale reserved widthTickerView.update(attributed:) resets visibleTextWidth to 0 when the string is empty, preventing a false 280px text region from persisting in the layout.
  • Show zero-value assetsCompactTickerView.renderPieces() no longer skips totalAssets when the value is exactly 0, consistent with the user's toggle preference.

Pullfrog  | View workflow run | Using DeepSeek Flash𝕏

@TNT-Likely

Copy link
Copy Markdown
Owner

@1254455745 多谢拆分提交!这个 PR 目前和 main 有冲突了 —— #15 / #18(自动宽度)/ #21 / #22 已经合入 main,和本 PR 改动了同一批菜单栏 ticker 文件,所以产生了冲突。麻烦 rebase 到最新 main、解决冲突后再推一下,我这边复测通过就合入。🙏

@1254455745
1254455745 force-pushed the review/empty-menu-state-v2 branch from 5905e70 to 3eb8b0b Compare June 4, 2026 14:52
@1254455745

Copy link
Copy Markdown
Contributor Author

重新提交啦,你看看~

@TNT-Likely
TNT-Likely merged commit f834ef5 into TNT-Likely:main Jun 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants