Skip to content

固定模式增加箭头显示开关 - #19

Merged
TNT-Likely merged 1 commit into
TNT-Likely:mainfrom
1254455745:review/fixed-arrow-toggle-v2
Jun 5, 2026
Merged

固定模式增加箭头显示开关#19
TNT-Likely merged 1 commit into
TNT-Likely:mainfrom
1254455745:review/fixed-arrow-toggle-v2

Conversation

@1254455745

Copy link
Copy Markdown
Contributor

这个 PR 给固定模式增加是否显示涨跌箭头的设置,让固定模式可以覆盖原来极简模式的一部分使用场景。

改动内容:

  • 固定模式支持显示或隐藏涨跌方向箭头。
  • 设置页增加对应开关。
  • 保持原有汇总指标开关逻辑不变。

验证:

  • 单独分支构建通过。

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — Adds a "Show direction arrow" toggle for the compact (fixed) display mode, letting users show or hide the ↑/↓ arrows next to PnL values, with migration from the deprecated .minimal mode.

  • New persistence key (ticker_show_direction_arrow) and @Published preference showDirectionArrow
  • Migration: existing .minimal users shift to .compact with arrows enabled, and .minimal is removed from the display-mode picker
  • Rendering: CompactTickerView.piece() conditionally prepends arrows based on showsDirectionArrow
  • Settings UI: toggle appears when displayMode == .compact || displayMode == .minimal
  • Localization: en + zh-Hans strings

Pullfrog  | View workflow run | Using DeepSeek Flash𝕏

@TNT-Likely

Copy link
Copy Markdown
Owner

@1254455745 多谢拆分提交!这个 PR 目前和 main 有冲突了 —— #15 / #18(自动宽度)/ #21 / #22 已经合入 main,和本 PR 改动了同一批菜单栏 ticker 文件,所以产生了冲突。麻烦 rebase 到最新 main、解决冲突后再推一下,我这边复测通过就合入。🙏

@1254455745
1254455745 force-pushed the review/fixed-arrow-toggle-v2 branch from 30f2ae6 to 7c8675c Compare June 4, 2026 14:52
@1254455745
1254455745 force-pushed the review/fixed-arrow-toggle-v2 branch from 7c8675c to 393406d Compare June 4, 2026 15:23
@1254455745

Copy link
Copy Markdown
Contributor Author

重新提交啦,你看看~

@TNT-Likely
TNT-Likely merged commit e06e8e7 into TNT-Likely:main Jun 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants