整理菜单栏内容显示选项 - #17
Merged
TNT-Likely merged 2 commits intoJun 5, 2026
Merged
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — This PR reorganizes menu bar content display options into a dedicated "Display Content" section, adds three new toggles (showAppIcon, showQuoteCode, showQuoteName), migrates the legacy .scrollNoCode display mode to .scroll + showQuoteCode = false, and refactors icon/text layout positioning across all four ticker view types.
- Add
showAppIcon,showQuoteCode,showQuoteNamepreferences — Three new@Publishedproperties inTickerPreferencesfollowing the established persistence pattern - Legacy
.scrollNoCodemigration — On init, detects the old mode and maps to.scroll+showQuoteCode = false, persisting both changes leadingTextXrefactoring — All four ticker views extract icon-aware horizontal offset into a private computed property, replacing hardcodediconWidth + 6calculations- Conditional icon rendering — Each view's
draw(_:)gates icon behindif showsIcon - Conditional quote text in
TickerRenderer—piece(for:)conditionally appends code and name segments - UI reorganization — New "Display Content"
SectioninTickerPane; code/name toggles shown only for scroll and carousel modes - Localization — Four new
.xcstringsentries (en + zh-Hans)
DeepSeek Flash | 𝕏
Owner
|
@1254455745 多谢拆分提交!这个 PR 目前和 |
1254455745
force-pushed
the
review/menu-content-options-v2
branch
from
June 4, 2026 14:52
e2baac3 to
33e8ca2
Compare
1254455745
force-pushed
the
review/menu-content-options-v2
branch
from
June 4, 2026 15:23
33e8ca2 to
5a55370
Compare
Contributor
Author
|
重新提交啦,你看看~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

这个 PR 重新整理菜单栏设置里的内容显示选项,保留原软件命名,同时把几个显示开关拆得更清楚。
改动内容:
验证: