Improve UI/UX follow-ups#28
Open
0xC0FEBABE wants to merge 13 commits into
Open
Conversation
Replace the hand-recorded module dependency facts with a mechanically derived graph from a scip-typescript index: 912 source-tracked facts (262 entities, 916 edges), enabling trustworthy impact/deps/reaches blast-radius queries. - add `pnpm faim:deps` (scripts/faim-scip-deps.mjs): index -> scan -> filter generated/ -> import --replace; idempotent - add @sourcegraph/scip-typescript devDep - gitignore index.scip (40MB, regenerated) and scip-deps*.jsonl - backfill --files provenance on the remaining hand-recorded facts (12 entities + 14 endpoints); untracked 83 -> 1 (faim self-fact only) faim state: 0 stale, 0 schema errors, 0 violations, validate SUCCESS. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Quick Stats: emphasize values over labels, drop dead hover (T1) - Wording: "Cancel poll", "Hide voting panel", named phase steps (T2) - Poll timer: 4 presets + validated number input; bounds-check (1-720, integer) before hitting the API instead of sending NaN (T3) - Poll duration: 10 presets instead of 144 generated options (T4) - Drop Material Symbols web font; inline the one glyph as SVG (T5) - Tone background watermark opacity 20% -> 8% (T6) Also loosen OrdersRail isPhase3Due to match the "3/3" phase fraction rather than the exact label string, so phase wording can change freely. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- drop obsolete office-poll-schedule -> src/lib/types dep edge - rehash 8 unchanged import-graph facts after source byte changes Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- refresh scip-derived import graph via `pnpm faim:deps` (914 facts re-imported) - rehash 20 unchanged service-level dep facts for poll/pollCreation/ officePollSchedule (main changed logic, not their import edges) faim validate: clean (0 stale, 0 violations). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- setup.ts: steal Prisma migration locks older than 60s (leaked by killed runs, caused 120s spin per test file) and bound migrate execSync at 60s - validate.ps1: stream check output through the pipeline, printing one progress dot per output line so long checks are visibly alive; replaces silent temp-file capture Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fastify 5.8->5.10, @fastify/static 9->10; drop effect override; allow-build pins for brace-expansion/fast-uri with release-age exclusions Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Implemented UI/UX quick wins from
reports/ui-ux-assessment.md1/3,2/3,3/3) after reverting the expanded text labels.Improved confirmations, modal accessibility, and async feedback
ConfirmDialog/useConfirmDialog.window.confirmusage with themed modal confirmations.Modal.ToastProviderwith anaria-livenotification region.Improved UI consistency
Button,Input,Select,Card, andsectionTitleClassacross the main lunch-flow views.Added FAIM dependency graph automation
faim:depsscript backed byscip-typescript..gitignore..faimdependency facts.AGENTS.md.Updated
reports/ui-ux-assessment.md