Skip to content

Improve UI/UX follow-ups#28

Open
0xC0FEBABE wants to merge 13 commits into
mainfrom
feature/ui-ux-followups
Open

Improve UI/UX follow-ups#28
0xC0FEBABE wants to merge 13 commits into
mainfrom
feature/ui-ux-followups

Conversation

@0xC0FEBABE

Copy link
Copy Markdown
Collaborator

What changed

  • Implemented UI/UX quick wins from reports/ui-ux-assessment.md

    • Simplified poll timer controls to a short preset list plus validated numeric input.
    • Reduced poll duration options from the full 5-minute range to practical presets.
    • Fixed Quick Stats visual hierarchy and removed misleading hover states.
    • Toned down the global watermark opacity.
    • Removed the external Material Symbols Google Fonts request and replaced the single glyph with inline SVG.
    • Kept the rail phase labels compact (1/3, 2/3, 3/3) after reverting the expanded text labels.
    • Changed the ringing clock animation from a swing/rotation to a subtle vibration.
  • Improved confirmations, modal accessibility, and async feedback

    • Added shared ConfirmDialog / useConfirmDialog.
    • Replaced native window.confirm usage with themed modal confirmations.
    • Added focus trap, initial focus, focus restore, Escape handling, and body scroll lock to Modal.
    • Added ToastProvider with an aria-live notification region.
    • Migrated many action-level success/error messages to toasts while keeping field validation inline.
  • Improved UI consistency

    • Adopted shared Button, Input, Select, Card, and sectionTitleClass across the main lunch-flow views.
    • Normalized the worst radius/tracking inconsistencies.
    • Updated affected client tests for confirmation, modal, and toast behavior.
  • Added FAIM dependency graph automation

    • Added a faim:deps script backed by scip-typescript.
    • Added generated SCIP artifacts to .gitignore.
    • Refreshed .faim dependency facts.
    • Documented the FAIM write-lock discovery in AGENTS.md.
  • Updated reports/ui-ux-assessment.md

    • Reconciled the report with current code reality.
    • Moved fixed issues out of the active flaw list.
    • Documented remaining open UI/UX work: mobile rail layout, phase stepper, tied-poll confirmation wording, and rail CTA/status split.

0xC0FEBABE and others added 10 commits July 6, 2026 13:56
Replace the hand-recorded module dependency facts with a mechanically
derived graph from a scip-typescript index: 912 source-tracked facts
(262 entities, 916 edges), enabling trustworthy impact/deps/reaches
blast-radius queries.

- add `pnpm faim:deps` (scripts/faim-scip-deps.mjs): index -> scan ->
  filter generated/ -> import --replace; idempotent
- add @sourcegraph/scip-typescript devDep
- gitignore index.scip (40MB, regenerated) and scip-deps*.jsonl
- backfill --files provenance on the remaining hand-recorded facts
  (12 entities + 14 endpoints); untracked 83 -> 1 (faim self-fact only)

faim state: 0 stale, 0 schema errors, 0 violations, validate SUCCESS.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Quick Stats: emphasize values over labels, drop dead hover (T1)
- Wording: "Cancel poll", "Hide voting panel", named phase steps (T2)
- Poll timer: 4 presets + validated number input; bounds-check
  (1-720, integer) before hitting the API instead of sending NaN (T3)
- Poll duration: 10 presets instead of 144 generated options (T4)
- Drop Material Symbols web font; inline the one glyph as SVG (T5)
- Tone background watermark opacity 20% -> 8% (T6)

Also loosen OrdersRail isPhase3Due to match the "3/3" phase fraction
rather than the exact label string, so phase wording can change freely.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- drop obsolete office-poll-schedule -> src/lib/types dep edge
- rehash 8 unchanged import-graph facts after source byte changes

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- refresh scip-derived import graph via `pnpm faim:deps` (914 facts re-imported)
- rehash 20 unchanged service-level dep facts for poll/pollCreation/
  officePollSchedule (main changed logic, not their import edges)

faim validate: clean (0 stale, 0 violations).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@0xC0FEBABE
0xC0FEBABE requested a review from TKlerx July 22, 2026 12:54
@0xC0FEBABE 0xC0FEBABE self-assigned this Jul 22, 2026
0xC0FEBABE and others added 2 commits July 23, 2026 11:00
- setup.ts: steal Prisma migration locks older than 60s (leaked by
  killed runs, caused 120s spin per test file) and bound migrate
  execSync at 60s
- validate.ps1: stream check output through the pipeline, printing one
  progress dot per output line so long checks are visibly alive;
  replaces silent temp-file capture

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fastify 5.8->5.10, @fastify/static 9->10; drop effect override;
allow-build pins for brace-expansion/fast-uri with release-age
exclusions

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@0xC0FEBABE 0xC0FEBABE changed the title Improve UI/UX follow-ups and FAIM dependency scanning Improve UI/UX follow-ups Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant