UI/UX polish, planned by Fable, implemented based on FAIM+SCIP dependency graph tooling#27
Closed
0xC0FEBABE wants to merge 7 commits into
Closed
UI/UX polish, planned by Fable, implemented based on FAIM+SCIP dependency graph tooling#270xC0FEBABE wants to merge 7 commits into
0xC0FEBABE wants to merge 7 commits into
Conversation
Replace the hand-recorded module dependency facts with a mechanically derived graph from a scip-typescript index: 912 source-tracked facts (262 entities, 916 edges), enabling trustworthy impact/deps/reaches blast-radius queries. - add `pnpm faim:deps` (scripts/faim-scip-deps.mjs): index -> scan -> filter generated/ -> import --replace; idempotent - add @sourcegraph/scip-typescript devDep - gitignore index.scip (40MB, regenerated) and scip-deps*.jsonl - backfill --files provenance on the remaining hand-recorded facts (12 entities + 14 endpoints); untracked 83 -> 1 (faim self-fact only) faim state: 0 stale, 0 schema errors, 0 violations, validate SUCCESS. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Quick Stats: emphasize values over labels, drop dead hover (T1) - Wording: "Cancel poll", "Hide voting panel", named phase steps (T2) - Poll timer: 4 presets + validated number input; bounds-check (1-720, integer) before hitting the API instead of sending NaN (T3) - Poll duration: 10 presets instead of 144 generated options (T4) - Drop Material Symbols web font; inline the one glyph as SVG (T5) - Tone background watermark opacity 20% -> 8% (T6) Also loosen OrdersRail isPhase3Due to match the "3/3" phase fraction rather than the exact label string, so phase wording can change freely. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- drop obsolete office-poll-schedule -> src/lib/types dep edge - rehash 8 unchanged import-graph facts after source byte changes Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- refresh scip-derived import graph via `pnpm faim:deps` (914 facts re-imported) - rehash 20 unchanged service-level dep facts for poll/pollCreation/ officePollSchedule (main changed logic, not their import edges) faim validate: clean (0 stale, 0 violations). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch delivers the first UI/UX cleanup batch from
reports/ui-ux-assessment.md, plus supporting FAIM dependency-graph tooling.UI/UX quick wins
Implemented the small visual/usability fixes from T1–T6:
Step 2/3 · OrderingModal and confirmation improvements
Implemented T7 + T10:
components/ui/ConfirmDialog.tsx.window.confirmflows with accessible modal confirmations.ui/Modal.tsxwith:This improves destructive/admin flows without adding a new dependency.
UI primitive adoption and styling consistency
Implemented T8 + T9:
Button,Input,Select→rounded-lgCard→rounded-2xlsectionTitleClassinui/Section.tsx.PollIdleViewPollActiveViewPollTiedViewOrdersRailFoodSelectionActiveViewFoodSelectionOrderingViewFoodSelectionOvertimeViewFoodSelectionCompletedViewFoodDeliveryViewHeaderTimerActionHeaderMinutesActionDropdownMealOnboardingDialogFoodSelectionAbortControlNative checkboxes remain native; no checkbox primitive was added.
FAIM dependency graph support
Added project support for refreshing FAIM import/dependency facts from SCIP:
@sourcegraph/scip-typescript.pnpm faim:deps.scripts/faim-scip-deps.mjs.index.scipscip-deps*.jsonl.faim/derived/*dependency facts.Documentation
reports/ui-ux-assessment.mdwith completed task status through T10.reports/is ignored by default, so this file was force-added because it is the assessment source for this batch.Validation run
pnpm typecheck✅pnpm lint✅ no errors; existing warning baseline remainsfaim validate✅faim status✅ no stale facts, no schema errors, no violationsCommit list
e361af0 feat(faim): machine-derive dependency graph from SCIP index8ce90cf feat(ui): batch-1 UX quick wins (T1-T6)5565fd0 chore(faim): refresh stale test-file import facts6a9979b chore(faim): reconcile dependency graph after merging mainbe181e0 Improve modal confirmations