Skip to content

158 vehicle location information#164

Merged
KatrinaMKaiser merged 10 commits into
mainfrom
158-vehicle-location-information
Oct 16, 2023
Merged

158 vehicle location information#164
KatrinaMKaiser merged 10 commits into
mainfrom
158-vehicle-location-information

Conversation

@jlstpaul

@jlstpaul jlstpaul commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Addresses #158 adding location_ping_id fields to passenger_events and fare_transactions.

@github-actions

github-actions Bot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

@jlstpaul jlstpaul requested a review from e-lo October 2, 2023 00:36
@jlstpaul

jlstpaul commented Oct 3, 2023

Copy link
Copy Markdown
Contributor Author

@SorenSpicknall @e-lo can you tell me what I’m doing wrong here.

@SorenSpicknall

SorenSpicknall commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

@SorenSpicknall @e-lo can you tell me what I’m doing wrong here.

The error you're seeing isn't your fault - a file used for validation was deleted in a previous PR, and the relevant test just didn't run after that until you drafted and submitted these changes. I've opened #165 to address the missing file.

@botanize botanize left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi John,

I suggest simplifying the language used to describe location_ping_id to avoid confusion between table names and observations.

Comment thread spec/fare_transactions.schema.json Outdated
Comment thread spec/passenger_events.schema.json Outdated

@KatrinaMKaiser KatrinaMKaiser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned from @SorenSpicknall today that you'll also need to update the sample CSVs

@github-actions

Copy link
Copy Markdown
Contributor

Data Validation Report

Sample Status
./samples/template/TIDES ✔️

@github-actions

Copy link
Copy Markdown
Contributor

Data Validation Report

Sample Status
./samples/template/TIDES ✔️

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

Data Validation Report

Sample Status
./samples/template/TIDES ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants