Pr2 sample data add workflow#101
Conversation
Use this instead because it is more configurable/extensible than the redirects.
1. Add example data (imperfect for now) generated by script `create_example` in data/example/data 2. Update validate-data GH action to refer to correct repos.
- Linted - Auto-generated tabular-data-package datapackage.json from script - Removed random data and the scripts to generate it, kept csv templates - Added readmes and documentation about each example in directory -
- Rendered samples as a table w/out readmes - Renamed data folders to samples and TIDES - Added metadata to datapackage.json about vendors, github handles, NTDID, agency name and exposed in documentation - Updated documentation for consistency - Renamed 'example' to 'template' to be more consistent with what it is
- changed workflow title to fix link with spaces - moved datapackage.json up one directory, updated docs, updated source refs - added missing --schema flag
per request
- Removes refs to template - Removes refs to github workflows
- and updates documentation
botanize
left a comment
botanize
left a comment
There was a problem hiding this comment.
- Remove all files except
validate_samples.yml - we need
--schema-syncflag for the frictionless validator
| - 'data/*/TIDES/*' | ||
| - 'spec/*' | ||
| pull_request: | ||
| paths: | ||
| - 'data/*/TIDES/*' | ||
| - 'spec/*' |
There was a problem hiding this comment.
I think data/*/TIDES/* needs to be samples/*/TIDES/*
There was a problem hiding this comment.
Remove all files except validate_samples.yml
Not sure why? this is just tiering off of other files that are already there - shouldn't be adding anything else.
There was a problem hiding this comment.
This PR makes changes also proposed in #100, but should be independent or "stacked" on that PR, otherwise you'll be resolving merge conflicts when trying to merge this PR. Additionally, all files except validate_samples.yml are irrelevant to the purpose of this PR!
| - name: Validate data | ||
| uses: frictionlessdata/repository@v2 | ||
| with: | ||
| packages: "data/*/TIDES/datapackage.json" |
There was a problem hiding this comment.
data => samples, e.g., samples/*/TIDES/datapackage.json
| - name: Checkout repository | ||
| uses: actions/checkout@v2 | ||
| - name: Validate data | ||
| uses: frictionlessdata/repository@v2 |
There was a problem hiding this comment.
Is there any way to pass --schema-sync to this action? Otherwise it will fail when option fields are left out of the csvs.
|
Replaced by: #104 |
2 participants
Pull Request
This PR adds a GitHub workflow for sample validation and associated documentation.
This reflects the splitting up of the original PR reflecting Issue #40 (PR #75) per the suggestion made by @botanize