fix(examples): preserve geo3k response budget#2140
Open
zhangdw156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_new_tokensis treated as response budget, not total prompt+response budget.rollout_max_context_lenis also set, use the tighter remaining context/response budget.Why
sampling_params["max_new_tokens"]comes fromrollout_max_response_len. The current multi-turn example subtractslen(sample.tokens), which includes the prompt, so long prompts can prematurely truncate or reduce the model's response budget before generation starts.Tests
uvx --from pytest pytest tests/test_geo3k_vlm_multi_turn_budget.py -quvx ruff check examples/geo3k_vlm_multi_turn/rollout.py tests/test_geo3k_vlm_multi_turn_budget.pygit diff --check