docs(examples): fix broken markdown links in rollout_buffer and examples#2137
Open
CalvinXKY wants to merge 1 commit into
Open
docs(examples): fix broken markdown links in rollout_buffer and examples#2137CalvinXKY wants to merge 1 commit into
CalvinXKY wants to merge 1 commit into
Conversation
rollout_buffer README: point Qwen3-4B setup links to docs/{en,zh}/examples/ instead of non-existent docs/{en,zh}/models/
examples/README: link low_precision and reproducibility to the advanced docs pages (no matching example subdirectories exist)
delta_weight_sync README: replace missing W&B plot embeds with metric names; the PNG assets were never committed since THUDM#1806
Signed-off-by: kaiyuan <kyxiezju@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several broken relative links in markdown docs.
The rollout_buffer README change addresses the same issue already fixed in the vime fork: vllm-project/vime#295. Both repos had links pointing at
docs/{en,zh}/models/qwen3-4B.md, but the doc lives underdocs/{en,zh}/examples/. vime is built on slime, not the other way around — this PR brings the equivalent fix back to slime and covers a few related broken links found in the same scan.Changes
docs/{en,zh}/models/qwen3-4B.md->docs/{en,zh}/examples/qwen3-4B.mdlow_precisionandreproducibilitytodocs/en/advanced/pages (no matching example subdirectories exist)Verification
pre-commit run --all-filespassed locally