[WIP] Dynamic TT attributes#192
Closed
devreal wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
…tibility Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Contributor
Author
|
Ideas for per-terminal attributes:
|
Contributor
Author
|
Discussion at the meeting Roanoke (2/4/2022): we can probably replace this with a policy-based design where the user overrides the default policy class and template the TT on it to allow the compiler to fully inline mapping functions. |
Contributor
|
Superseded by PR #226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a generic interface for attributes in TTs. An attribute may store either a value of specified type or a function mapping a task id to a value. Attributes may be set dynamically, i.e., the value and function can be changed at runtime. Setting a value or function overrides any previously set value or function.
Attributes availabe so far:
set_keymap)set_priomap)(*) not yet implemented
We may want to add an attribute to denote pure tasks once we support them.
Attributes are set using
or
These attributes are currently defined for TTs. Should they be specific to an
op, i.e., do we want different attributes foropandop_cuda?Do we want attributes on a per-terminal basis? Which ones?