[REFACTOR/#219] 도연 QA - #221
Conversation
- BackHandler 처리 - 다이얼로그 떠있는 경우는 닫는 처리(홈 이동X) - 탑바 뒤로가기 클릭 시에도 홈 이동
- 기존 데이터 로드마다 Loading 상태를 전환해 로딩 중에는 빈 화면 노출돼 깜박 거리는 걸로 보였음
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (1)
📝 WalkthroughWalkthrough강사 레슨 상세 화면의 초기 상태와 뒤로가기 동작이 변경되었으며, 홈 이동 시 백스택을 정리하도록 연결되었습니다. 매칭 카드의 가격 표시, 하단 바 눌림 배경 범위, 푸시 알림 아이콘도 수정되었습니다. Changes강사 레슨 상세 흐름
매칭 및 하단 바 UI
푸시 알림 아이콘
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
core/ui/src/main/java/com/ssing/core/ui/common/component/SsingBottomBar.kt (1)
120-129: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win스크린 리더(TalkBack) 중복 읽기 방지를 위한 접근성 개선
동일한 탭 이름(
stringResource(tab.titleRes))이 하단의Text컴포저블을 통해 이미 제공되고 있습니다.Icon의contentDescription에도 같은 값을 넣으면 화면 읽기 프로그램 사용 시 탭 이름이 중복해서 음성 출력됩니다.접근성 점검 기준에 따라
Icon의contentDescription을null로 설정하여 의미 없는 중복 읽기를 방지하는 것을 권장합니다.♻️ 수정 제안
Icon( imageVector = ImageVector.vectorResource(iconRes), - contentDescription = stringResource(tab.titleRes), + contentDescription = null, tint = textColor, ) Text( text = stringResource(tab.titleRes),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/ui/src/main/java/com/ssing/core/ui/common/component/SsingBottomBar.kt` around lines 120 - 129, Update the Icon call in the bottom bar tab item to set contentDescription to null, while leaving the existing Text label and other icon properties unchanged.Source: Path instructions
presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailScreen.kt (1)
21-23: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value사용되지 않는
navigateBack파라미터 제거.뒤로가기 동작이
navigateToHome으로 대체됨에 따라 기존의navigateBack파라미터는 더 이상 사용되지 않습니다. 혼동을 방지하기 위해 선언부와 호출부에서 모두 제거하는 것을 권장합니다.
presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailScreen.kt#L21-L23:LessonDetailRoute에서navigateBack파라미터 선언을 제거하세요.presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/navigation/InstructorLessonNavigation.kt#L27-L28:LessonDetailRoute호출 시 전달하는navigateBack = navController::popBackStack인자를 제거하세요. (이 작업을 수행하면instructorLessonNavGraph의navController파라미터도 더 이상 사용되지 않게 되므로 함께 정리할 수 있습니다.)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailScreen.kt` around lines 21 - 23, Remove the unused navigateBack parameter from LessonDetailRoute and remove the corresponding navigateBack = navController::popBackStack argument from InstructorLessonNavigation.kt. After removing that argument, clean up the now-unused navController parameter in instructorLessonNavGraph if applicable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core/notification/src/main/java/com/ssing/core/notification/PushNotificationService.kt`:
- Line 85: Update the small icon configured in the PushNotificationService
notification builder to use the dedicated monochrome notification drawable
instead of applicationInfo.icon. Select the existing transparent-background
notification icon resource and leave the rest of the notification configuration
unchanged.
---
Nitpick comments:
In `@core/ui/src/main/java/com/ssing/core/ui/common/component/SsingBottomBar.kt`:
- Around line 120-129: Update the Icon call in the bottom bar tab item to set
contentDescription to null, while leaving the existing Text label and other icon
properties unchanged.
In
`@presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailScreen.kt`:
- Around line 21-23: Remove the unused navigateBack parameter from
LessonDetailRoute and remove the corresponding navigateBack =
navController::popBackStack argument from InstructorLessonNavigation.kt. After
removing that argument, clean up the now-unused navController parameter in
instructorLessonNavGraph if applicable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 173738a1-13e1-4299-a43e-91ea58e15a6b
📒 Files selected for processing (8)
app/instructor/src/main/java/com/ssing/instructor/InstructorMainNavHost.ktcore/notification/src/main/java/com/ssing/core/notification/PushNotificationService.ktcore/ui/src/main/java/com/ssing/core/ui/common/component/SsingBottomBar.ktpresentation/consumer-matching/src/main/java/com/ssing/presentation/consumermatching/screen/ConsumerMatchingPendingScreen.ktpresentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/LessonDetailContract.ktpresentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/LessonDetailViewModel.ktpresentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/navigation/InstructorLessonNavigation.ktpresentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailScreen.kt
💤 Files with no reviewable changes (1)
- presentation/consumer-matching/src/main/java/com/ssing/presentation/consumermatching/screen/ConsumerMatchingPendingScreen.kt
2 participants
Related issue 🛠
Work Description ✏️
소비자-매칭ConsumerMatchingPendingScreen의예상 가격지우기강사-레슨뒤로가기 시 스택 지우고 홈으로 가게 변경navigateToBack을navigateToHome으로 변경BackHandler에서 모달 떠있는 경우 모달 닫기, 모달 없는 경우라면navigateToHome처리강사-레슨로딩 상태 제거loadLessonDetail에서LessonDetailPhase.Loading로phase를 변경,LessonDetailPhase.Loading일 때 UI는 빈 화면으로 노출되어phase변경마다 화면이 깜빡이는 것으로 보였음loadLessonDetail시LessonDetailPhase.Loading변경하지 않음강사-레슨초기 상태Init으로 변경Loading상태를Init으로 워딩 변경State초기값을 더미 데이터 들어간Before대신Init으로 변경푸시 알림 아이콘 변경
바텀네비바 onPressed 회색 배경 적용 범위 변경
Uncompleted Tasks 😅
To Reviewers 📢
Summary by CodeRabbit
새로운 기능
개선 사항