[REFACTOR/#213] 예지 QA - #218
Merged
Merged
Conversation
📝 WalkthroughWalkthrough강습 상세 4종 화면의 본문 스크롤 구조와 Changes강습 상세 화면 레이아웃
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailBeforeScreen.kt`:
- Line 108: Replace the direct Blue50 usage in the background modifiers of
LessonDetailBeforeScreen.kt (108-108), LessonDetailOngoingScreen.kt (72-72),
LessonDetailCompletedScreen.kt (72-72), and LessonDetailCanceledScreen.kt
(74-74) with the appropriate semantic color from SSINGTheme.colors, preserving
the existing background styling while enabling theme and dark-mode support.
- Around line 105-118: Remove the weight modifiers from the scrollable content
in LessonDetailBeforeScreen.kt lines 105-118, LessonDetailOngoingScreen.kt lines
69-82, LessonDetailCompletedScreen.kt lines 69-82, and both occurrences in
LessonDetailCanceledScreen.kt lines 71-84. In LessonDetailBeforeScreen, change
the root Column background to SSINGTheme.colors.backgroundNormal and wrap the
top Spacer and LessonBanner in a Blue50-background container so the intended
background fill remains without weight-based sizing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d4d89a10-af68-4acb-a036-6a8516988859
📒 Files selected for processing (4)
presentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailBeforeScreen.ktpresentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailCanceledScreen.ktpresentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailCompletedScreen.ktpresentation/instructor-lesson/src/main/java/com/ssing/presentation/instructorlessondetail/screen/LessonDetailOngoingScreen.kt
Collaborator
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
Summary by CodeRabbit
Summary by CodeRabbit