Lua Tidying#841
Open
warmCabin wants to merge 34 commits into
Open
Conversation
Just want to see what happens. If the performance sucks, I'll try it with 5 or 6 bits. If the difference is negligible, I'll remove it properly.
I added this for testing purposes; you might find it useful, too. I imagine I'm going to revert this before merging.
* set a minimum track size to prevent controls from overlapping * alter the RedrawWindow call in WM_SIZE to update children This prevents a stale canvas hall-of-mirrors effect * make IDOK run the script instead of closing the window * clean up weird reentrant IDCANCEL/WM_CLOSE flow Shoutouts to that commented out goto!
Skill issue, sorry...
Author
|
FREE AT LAST! Everything's working again. The Qt build keeps timing out for whatever reason, but when it doesn't, it works. The Mac build is back to failing with that "/bin/sh: -c: line 0: syntax error near unexpected token `>'" error. |
Author
|
I gave up trying to fix the Mac builds. I have a couple more Lua ideas I want to explore, but I'm going to call it here for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to fix some Lua issues I've dealt with over the years. I kept working off of #802 because I am lazy. Just ignore any palette-related stuff for now, I'll rebase eventually.
-luaargsargument.print()arguments with tabs, not spaces (all frontends)I provided stubs in the Qt drivers, so the SDL/Qt builds at least still work.