Unify ILRepack across plugin/workflow-activity/PdPackage#62
Open
zekelinAlex wants to merge 7 commits into
Open
Unify ILRepack across plugin/workflow-activity/PdPackage#62zekelinAlex wants to merge 7 commits into
zekelinAlex wants to merge 7 commits into
Conversation
The exclusion list claimed to skip Microsoft.Xrm.Sdk* (per README and
header comment) but only filtered three exact filenames in practice:
Microsoft.Xrm.Sdk, .Deployment, .Workflow. Any future or third-party
Microsoft.Xrm.Sdk.<x>.dll that ended up in OutDir would be merged into
the plugin assembly and cause runtime version clashes inside the
Dataverse sandbox.
Replace the two specific Deployment/Workflow entries with a
StartsWith('Microsoft.Xrm.Sdk.') prefix check covering all sub-
namespaces. Exact 'Microsoft.Xrm.Sdk' (no trailing dot) stays as its
own entry so the base assembly is still excluded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, PdPackage and plugin/workflow-activity each ran ILRepack their own
way. Different NuGet (
ilrepackvsILRepack.Lib.MSBuild.Task), differentinvocation, different switches, three copies of an
empty stub file. Same job, three implementations. This PR collapses them.
what changed:
TalxisMergeOutputAssembly(renamed fromTalxisMergePluginDependenciessince PdPackage uses it too). plugin,workflow-activity, and PdPackage each wire it onto
AfterTargets="Build"themselves. Tasks doesn't auto-hook, so Solution/Pcf/CodeApp/ScriptLibrary
don't get dragged in.