Adjusted support for windows path normalization#132
Open
zdeneksrejber wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Windows-specific bug in MCP path normalization where file URI local paths like /c:/Users/project (as returned by Uri.LocalPath for VS Code's lowercase-drive roots) were being passed straight to Path.GetFullPath, producing duplicated-drive results like C:\c:\Users\project. The fix strips the leading / for /<letter>:/... inputs on Windows before any home-expansion logic runs, and treats drive-qualified ~ segments (e.g. C:\~\Sources\project) as literal filesystem paths rather than home-relative.
Changes:
- Add
TryNormalizeWindowsFileUriDrivePathto strip the leading slash from/<drive>:/...early inExpandHomeRelativePathon Windows. - Add tests covering VS Code lowercase-drive URIs, the duplicate-drive regression, and drive-qualified
~paths in bothRootsServiceTestsandMcpPathNormalizerTests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/TALXIS.CLI.MCP/McpPathNormalizer.cs | Adds early Windows file-URI drive-path normalization to drop the leading /. |
| tests/TALXIS.CLI.Tests/MCP/RootsServiceTests.cs | Adds regression tests for lowercase-drive URIs and drive-qualified ~ handling. |
| tests/TALXIS.CLI.Tests/MCP/McpPathNormalizerTests.cs | Adds tests for drive-qualified tilde paths and file-URI drive-path leading-slash normalization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/c:/...Uri.LocalPathinputs before home expansion~as normal filesystem paths