Fix compatibility with Lootr 1.20.34.101#8
Merged
Conversation
- Update Lootr dependency to 1.20.34.101 (YGHOIQfA) - Rename hasOpened → hasServerOpened in LootrAPIImplMixin target - Specify 3-param handleProviderOpen overload descriptor - Enable legacy Mixin AP for refmap generation - Add registry sync mixins for particles, advancements, loot, and tabs Fixes T0RNATO#7
|
just click merge already 😐 @T0RNATO |
Owner
|
My apologies - it seems I was never notified for either the issue or this PR, not sure why. My time is mostly occupied by study and work but I shall review this PR (and update this and other mods) in the coming week. |
Owner
|
@TheGobbo thank you for your PR and interest in this project (and knowledge of polymer APIs I didn't know haha) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.19.33.100to1.20.34.101(YGHOIQfA)LootrAPIImplMixin:hasOpenedwas renamed tohasServerOpenedand the 3-paramhandleProviderOpenoverload must be targeted explicitlyuseLegacyMixinAp = true) for proper refmap generationTest plan
Fixes #7