Skip to content

Typescript configuration#17

Closed
ricveal wants to merge 3 commits into
Swizec:masterfrom
ricveal:master
Closed

Typescript configuration#17
ricveal wants to merge 3 commits into
Swizec:masterfrom
ricveal:master

Conversation

@ricveal

@ricveal ricveal commented Aug 23, 2019

Copy link
Copy Markdown

Related with #16

  • Updated tsconfig.json to export type declarations.
  • Added typings property in package.json.
  • Updated tsconfig.json with more restricted rules, resolving todos.
  • Minor changes in typings to adjust output interface to Hooks interface.
  • Added Typescript as devDependency instead of assume that it is installed globally.
  • Added @types/react as devDependency. Now it is required due noImplicitAny rule.

@ricveal ricveal mentioned this pull request Aug 23, 2019
@kevynb

kevynb commented Oct 31, 2019

Copy link
Copy Markdown

Hello,

is there anything I can to to help this PR get merged?
I would love to see it closed so that I can use the lib in typescript projects without tsc complaining 😃

@jacek213

Copy link
Copy Markdown

@Swizec could u please look into this?

@breadadams

Copy link
Copy Markdown

@Swizec could I assist in getting this merged?

@saschagehlich

Copy link
Copy Markdown

@Swizec You still seem to be active on GitHub, but this repository seems abandoned. Do you need help maintaining it? This is an important PR.

@johnnyBira

johnnyBira commented May 27, 2020

Copy link
Copy Markdown

What's the hold up @Swizec ?
I'd alos like to offer my assistance if it's needed in order to get this merged.

@jacek213

Copy link
Copy Markdown

@Swizec is clearly a typescript hater!

@johnnyBira

johnnyBira commented May 27, 2020

Copy link
Copy Markdown

From what I understand @Swizec has already went trough the trouble of rewriting this library to TypeScript, all that's missing is to output the typings files and include them as part of the package, which this PR fixes.
I really don't understand why anyone would put in the effort and then just leave it hanging so close to being finished.

@jacek213 there are other important non TypeScript related PRs being ignored, like #28 which would be really nice to have.
This is a fairly successful library and people are actively contributing, but the lack of attention from its author seriously make me consider forking or looking for another alternative.

@sheldonj

Copy link
Copy Markdown

Maybe we just fork this bad boy? Since no one is actually maintaining this?

@ricveal

ricveal commented Jun 4, 2020

Copy link
Copy Markdown
Author

I think we can open a specific issue to discuss about forking the project. What do you think?
Currently, I'm using my own fork in my personal projects as temporal hack and I would be open to merge the open PRs if you like, but I think we should previously discuss it on an issue...

@sentilesdal

Copy link
Copy Markdown

@ricveal do you have a fork of this. I'd also like to have typings in the package.

@ricveal

ricveal commented Oct 14, 2020

Copy link
Copy Markdown
Author

@sentilesdal yes, I've forked useDimensions to add the functionality described on this PR. It's not available as independent npm package because I would prefer not to duplicate the project but due the inactivity of the repository, maybe it would be interesting to continue my fork as an independent project. What do you think, guys?

@sentilesdal

Copy link
Copy Markdown

I ended up using useMeasure from the react-use package which has a bunch of nice stuff FYI. I liked the implementation they used over there.

@ricveal ricveal closed this May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants