fix(ci): add production kit email config#1870
Merged
Merged
Conversation
d56141c to
bbee00d
Compare
bbee00d to
a5ab9fd
Compare
…d-config # Conflicts: # .github/workflows/_deploy-environment.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compass.yamlKIT_API_SECRETorKIT_USER_TAG_IDis missingWhy
Production signups were skipping
EmailService.tagNewUserIfEnabled()because deployedcompass.yamldid not include the existingemail.kitApiSecretandemail.kitUserTagIdconfig values.Validation
bun test self-host/docker-compose.test.tspasses: 20 pass, 0 failbun lintstill fails on existing unrelated repo issues: Biome schema version mismatch, import order inpackages/web/src/__tests__/patched-jest.d.ts, and two redundant boolean castsDeploy note
Before production deploy, set these on the GitHub production environment:
KIT_API_SECRETKIT_USER_TAG_ID