feat: add option to remove iframe from sessions#1316
Draft
olevski wants to merge 1 commit into
Draft
Conversation
For remote K8s clusters getting the iframes of sessions to work is fairly complicated dur to CORS/CSP. This is because the sesssion is running on one domain (for example dev.renku.ch) whereas the UI is running on another - like renkulab.io. For clusters we do not have control and are limited it is hard to properly configure these options. Also in some cases the configuration is required at the Jupyterlab or RStudio level which makes it hard to generalize. This is just a quick relief for currently active remote clusters in production being used right now where a lot of users are having trouble and really bad UX because the default button to open a session leads to a 50x page. We can think and work on a long term solution in the future so that we still have iframes or the same UI for remote sessions.
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1316.dev.renku.ch |
leafty
reviewed
May 21, 2026
Member
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
General comments:
- Why don't we tunnel the session http port?
- What if we only change the UI? Remote cluster -> open in new tab, "Open in iframe" as a secondary action.
Member
Author
I wanted to avoid this if possible. Not having tunneling is definitely simpler.
Yes this is an option but then all remote clusters do not have this problem - just some. And the iframe brings a lot of useful information. So with this one small change on the backend and the changes we would do on the frontend anyhow we can apply this only to clusters that have problems with iframes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For remote K8s clusters getting the iframes of sessions to work is fairly complicated dur to CORS/CSP. This is because the sesssion is running on one domain (for example dev.renku.ch) whereas the UI is running on another - like renkulab.io. For clusters we do not have control and are limited it is hard to properly configure these options. Also in some cases the configuration is required at the Jupyterlab or RStudio level which makes it hard to generalize. This is just a quick relief for currently active remote clusters in production being used right now where a lot of users are having trouble and really bad UX because the default button to open a session leads to a 50x page.
We can think and work on a long term solution in the future so that we still have iframes or the same UI for remote sessions.
/deploy