Feat: Enable CNB image extensions support in BuildStrategy#1262
Draft
SalimKayal wants to merge 1 commit into
Draft
Feat: Enable CNB image extensions support in BuildStrategy#1262SalimKayal wants to merge 1 commit into
SalimKayal wants to merge 1 commit into
Conversation
Coverage Report for CI Build 24503156387Coverage decreased (-1.2%) to 86.348%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions332 previously-covered lines in 16 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
renku-buildpacks-v3BuildStrategy to support Cloud Native Buildpacks image extensions, an experimental feature that allows extensions to generate Dockerfiles to customize build and run base images.What changed
The previous strategy used a single
/cnb/lifecycle/creatorcall to handle the entire build lifecycle. Thecreatorbinary does not invoke theextenderphase, which is required for image extensions to work. This PR replaces thecreatorwith explicit individual lifecycle phase calls.Key details
CNB_EXPERIMENTAL_MODE=warnis set to unlock experimental features (image extensions).0.12to0.15.extenderorbuilder:<layers>/generated/build/, theextender -kind=buildis used (which also runs the build phase internally, per spec).builderis called.extender -kind=runis only invoked if run Dockerfiles are found in<layers>/generated/run/.-run-imageflag removed from the exporter: it is only passed to theanalyzer, which writes the resolved reference toanalyzed.toml. The exporter reads fromanalyzed.tomland picks up extended run image layers from<layers>/extended/run/when applicable. Passing-run-imageexplicitly to the exporter would override the extended run image.Why this approach
extenderto be called explicitly: it is not part of thecreatorall-in-one binary.builderphase.Buildresources.References