Skip to content

Update Firebase/GoogleSignIn dependencies and deprecated OAuthProvider credential method #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vamsii777 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Firebase/GoogleSignIn dependencies and deprecated OAuthProvider credential method #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7cbef3
Update Firebase and GoogleSignIn dependencies
vamsii777 Sep 14, 2024
ca27b6c
Update deprecated credential method
vamsii777 Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ let package = Package(
],
dependencies: [
// Dependencies declare other packages that this package depends on.
.package(url: "https://github.com/firebase/firebase-ios-sdk.git", from: "11.0.0"),
.package(url: "https://github.com/google/GoogleSignIn-iOS.git", from: "7.0.0")
.package(url: "https://github.com/firebase/firebase-ios-sdk.git", from: "11.2.0"),
.package(url: "https://github.com/google/GoogleSignIn-iOS.git", from: "8.0.0")
],
targets: [
// Targets are the basic building blocks of a package, defining a module or a test suite.
Expand Down
3 changes: 1 addition & 2 deletions Sources/SwiftfulFirebaseAuth/Providers/FirebaseAuthProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ struct FirebaseAuthProvider: AuthProvider {

// Convert Apple Auth to Firebase credential
let credential = OAuthProvider.credential(
withProviderID: AuthProviderOption.apple.rawValue,
providerID: AuthProviderID.apple,
idToken: appleResponse.token,
rawNonce: appleResponse.nonce
)
Expand Down Expand Up @@ -213,7 +213,6 @@ struct FirebaseAuthProvider: AuthProvider {
return Auth.auth().currentUser
}


private enum AuthError: LocalizedError {
case noResponse
case userNotFound
Expand Down