Skip to content

Foundational audit: a11y main+skip link + lodash vuln fix#13

Merged
Surfrrosa merged 1 commit into
mainfrom
audit/2026-06-09
Jun 9, 2026
Merged

Foundational audit: a11y main+skip link + lodash vuln fix#13
Surfrrosa merged 1 commit into
mainfrom
audit/2026-06-09

Conversation

@Surfrrosa

Copy link
Copy Markdown
Owner

Summary

Foundational audit pass: PragProg principles + site/ a11y + dep vuln scan.

  • a11y on site/: added `` landmark, visible-on-focus skip link, and `aria-hidden` on the decorative `←` arrow.
  • Dependency vuln: `npm audit fix` resolves the high-severity lodash CVEs (prototype pollution + code injection). Zero vulns remaining.
  • Coupling, DRY, zombie: all clean. Verdict: codebase is exemplary on those axes already. `shared/recommend.js` and `site/recommend.js` are byte-identical (the documented build-artifact pattern holds).

Full audit log: `docs/audits/2026-06-09.md`.

Test plan

  • `node scripts/validate-yaml.js` — 35 files, 0 errors
  • `node scripts/build-site.js` — 32 tools, 3 stacks
  • `npm audit` — 0 vulnerabilities
  • CI green on this PR

a11y on site/:
- Wrap the page's primary content in <main id="main-content"> so screen
  readers can jump to it via landmark navigation.
- Add a visible-on-focus skip-to-content link at the top of <body>.
  Adds new .skip-link class in style.css.
- Wrap the &larr; glyph in the "Back to start" button in
  aria-hidden="true" so screen readers don't announce it as content.
  Add explicit type="button".

Vuln:
- npm audit fix resolves the high-severity lodash CVEs (prototype
  pollution + code injection) via transitive bump. Zero vulns left.
- Also reconciles a pre-existing package.json ↔ package-lock.json drift
  on playwright's dep section.

Coupling, drift, zombie audits: clean. Codebase is exemplary on those
axes already. shared/recommend.js and site/recommend.js confirmed
byte-identical (the documented "don't fork the engine" rule holds).

validate-yaml and build-site both pass.

Full audit log: docs/audits/2026-06-09.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Surfrrosa Surfrrosa merged commit 3afe284 into main Jun 9, 2026
1 check passed
@Surfrrosa Surfrrosa deleted the audit/2026-06-09 branch June 9, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant