Skip to content

ci: use default E2E workers and GitHub reporter#585

Merged
Suree33 merged 3 commits into
mainfrom
ci/e2e-parallel-workers
Jun 28, 2026
Merged

ci: use default E2E workers and GitHub reporter#585
Suree33 merged 3 commits into
mainfrom
ci/e2e-parallel-workers

Conversation

@Suree33

@Suree33 Suree33 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Set Playwright workers to undefined at all times so the runner uses Playwright's default worker count
  • Add Playwright's built-in github reporter on GitHub Actions while keeping existing list and html reporters
  • Update the E2E docs to describe default worker behavior and GitHub Actions annotations

Test Plan

  • pnpm run format:check
  • pnpm run lint
  • CI=1 GITHUB_ACTIONS=true pnpm run test:e2e (Running 162 tests using 2 workers, 146 passed / 16 skipped; GitHub reporter emitted a Playwright Run Summary notice)

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Playwright workers config was changed from process.env.CI ? 1 : undefined to always undefined, removing the single-worker restriction in CI. Two lines in docs/e2e-testing.md were updated to document the resulting fullyParallel: true / workers: undefined behavior.

Changes

Playwright worker config and docs

Layer / File(s) Summary
Remove CI worker limit and update docs
playwright.config.ts, docs/e2e-testing.md
workers is now always undefined instead of 1 in CI; docs updated in the config key-points section and the GitHub Actions step description to reflect fullyParallel: true with default worker count.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 No more single-worker blues,
The tests run free as morning dew,
undefined the workers say,
Playwright picks its own sweet way,
Parallel hops throughout the day!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change of using Playwright's default E2E workers, though "GitHub reporter" is not reflected in the summary.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/e2e-parallel-workers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 27, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
blog 16e43d4 Commit Preview URL

Branch Preview URL
Jun 28 2026, 04:40 PM

@Suree33 Suree33 changed the title ci: run E2E tests with parallel workers ci: let Playwright choose E2E worker count Jun 28, 2026
@Suree33 Suree33 changed the title ci: let Playwright choose E2E worker count ci: use default E2E workers and GitHub reporter Jun 28, 2026
@Suree33 Suree33 merged commit 9d02eaf into main Jun 28, 2026
9 checks passed
@Suree33 Suree33 deleted the ci/e2e-parallel-workers branch June 28, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant