Android device description name#1
Closed
SuperKenVery wants to merge 1 commit into
Closed
Conversation
The description() method was using info.product_name.clone() as the device name, which makes all devices look the same (e.g., all showing 'Pixel 8'). PR RustAudio#965 fixed the name() method to include device_type and address for unique names, but description() was not updated. Extract device name logic into a private device_name() helper method and use it in both name() and description(), so that device.description().name() returns a distinguishable name like 'Pixel 8:BuiltinSpeaker' instead of just 'Pixel 8'. Co-authored-by: SuperKenVery <SuperKenVery@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Android
device.description().name()to return a unique device name instead of a generic product name.The
description()method in the AAudio backend was usinginfo.product_name.clone(), causing all Android devices to report the same name (e.g., "Pixel 8"). This was a similar issue to what PR RustAudio#965 previously fixed for thename()method. To resolve this and avoid deprecation warnings from callingself.name()withindescription(), the unique name-building logic was extracted into a private helper method, which bothname()anddescription()now utilize.