Hamming Window for full_fov RX beamforming#12
Open
RemingtonRohel wants to merge 17 commits into
Open
Conversation
* Updated all non-test experiments to pass tests. Changes include: - self.printing() changed to print() - decimation_scheme field added to all slices - rxonly added to listen-only slices
* Some experiment tests are now not applicable and have been moved to deprecated_tests * experiment_tests.csv no longer needed, each test class defines its own class method that returns the expected Exception that will be thrown and the error message.
* All tests pass when using exp_proto_refactor branch of Borealis.
Phased rx take 2 implementation of rx antenna pattern into unit tests and full fov experiment. Related to PR from SuperDARNCanada/borealis#432
Doreban
approved these changes
Feb 6, 2024
Doreban
left a comment
Doreban
left a comment
There was a problem hiding this comment.
I get the einsum notation mixed around a lot when dealing with numpy but it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply a Hamming window to the main array RX beamforming in full_fov.py