fix(browser-search): restore frecency function removed in #434#449
Merged
shobhit99 merged 1 commit intoMay 26, 2026
Merged
Conversation
The commit 8992618 (feat: combine browser and root search improvements SuperCmdLabs#434) accidentally deleted the frecency() helper but kept call sites in getLegacyCompletion(), causing a ReferenceError at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Commit 8992618 (PR #434 — "combine browser and root search improvements") deleted the
frecency()helper function but kept two call sites in the newgetLegacyCompletion()function, causing aReferenceError: frecency is not definedat runtime when the legacy completion path is hit (i.e. whenalphaChromiumRootSearchEnabledis off).Fix
Restore the accidentally deleted
frecency(entry: BrowserSearchEntry)function:This is the exact implementation that was removed — no logic changes.
Testing
ReferenceError