Skip to content

#SBCOSS-557 - removed bmgs hardcoding - #289

Merged
manjudr merged 6 commits into
Sunbird-Ed:release-8.0.0from
Rakshitha-D:bmgsFix
Sep 12, 2025
Merged

#SBCOSS-557 - removed bmgs hardcoding#289
manjudr merged 6 commits into
Sunbird-Ed:release-8.0.0from
Rakshitha-D:bmgsFix

Conversation

@Rakshitha-D

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 14, 2025

Copy link
Copy Markdown

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@manjudr
manjudr requested a review from Copilot August 18, 2025 05:32

This comment was marked as outdated.

@Rakshitha-D
Rakshitha-D changed the base branch from release-7.0.0 to release-8.0.0 August 18, 2025 06:57
@manjudr
manjudr requested a review from Copilot August 18, 2025 13:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes hardcoded BMGS (Board, Medium, Grade, Subject) properties from TypeScript interfaces to make them more flexible and generic. The changes support dynamic filtering and content modeling by replacing specific property definitions with generic key-value structures.

  • Replaced specific filter properties with a generic [key: string]: any interface
  • Refactored Content interface to use a base interface with generic property extension
  • Removed hardcoded BMGS and related educational metadata fields

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/services/course/interface/cs-course-service.ts Replaced specific filter properties (board, medium, gradeLevel, subject) with generic key-value mapping
src/models/content/index.ts Refactored Content interface to extend ContentBase with generic properties, removing hardcoded educational metadata fields

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread src/models/content/index.ts
Comment thread src/services/course/interface/cs-course-service.ts
manjudr
manjudr previously approved these changes Aug 19, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@manjudr
manjudr merged commit 318f058 into Sunbird-Ed:release-8.0.0 Sep 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants