#SBCOSS-557 - removed bmgs hardcoding - #289
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR removes hardcoded BMGS (Board, Medium, Grade, Subject) properties from TypeScript interfaces to make them more flexible and generic. The changes support dynamic filtering and content modeling by replacing specific property definitions with generic key-value structures.
- Replaced specific filter properties with a generic
[key: string]: anyinterface - Refactored Content interface to use a base interface with generic property extension
- Removed hardcoded BMGS and related educational metadata fields
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/services/course/interface/cs-course-service.ts | Replaced specific filter properties (board, medium, gradeLevel, subject) with generic key-value mapping |
| src/models/content/index.ts | Refactored Content interface to extend ContentBase with generic properties, removing hardcoded educational metadata fields |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.