Skip to content

Add subtitle toggle command on C key#480

Open
totimorpa wants to merge 1 commit into
Stremio:masterfrom
totimorpa:codex/subtitle-toggle-command
Open

Add subtitle toggle command on C key#480
totimorpa wants to merge 1 commit into
Stremio:masterfrom
totimorpa:codex/subtitle-toggle-command

Conversation

@totimorpa

@totimorpa totimorpa commented Apr 4, 2026

Copy link
Copy Markdown

Summary

  • add a global C keyboard command to toggle subtitle visibility in the player
  • reduce repeated "Subtitles loaded" notifications when subtitles are enabled via keyboard command
  • preserve first-time keyboard-enable behavior

Implementation

  • add application-level Action for C in main.qml
  • on keyboard-enable, set a short-lived suppression flag for subtitle-related mpv prop-change events
  • forward all other events unchanged

Why

  • keyboard subtitle toggling works, but repeated subtitle toast popups are noisy during playback
  • this keeps the command responsive while making repeated toggles less disruptive

Verification

  • qmllint main.qml passes
  • manual flow tested:
    1. play a video with subtitles available
    2. press C to toggle subtitles on/off
    3. subtitle toggle works
    4. repeated keyboard enables do not keep spamming subtitle toast

Scope

  • one file only: main.qml
  • no build-system or packaging changes

Tracking

@totimorpa

Copy link
Copy Markdown
Author

Linked feature request: Stremio/stremio-features#1766

@totimorpa

totimorpa commented Apr 4, 2026

Copy link
Copy Markdown
Author

Hi @core1024 and @Ivshti, when you have a moment, could you please review this PR?

It adds subtitle toggle on the C key in desktop (main.qml) and reduces repeated keyboard-triggered subtitle toast spam.

Feature request tracked here: Stremio/stremio-features#1766

Thanks for your time.

@kKaskak

kKaskak commented May 19, 2026

Copy link
Copy Markdown
Member

Hi @core1024 and @Ivshti, when you have a moment, could you please review this PR?

It adds subtitle toggle on the C key in desktop (main.qml) and reduces repeated keyboard-triggered subtitle toast spam.

Feature request tracked here: Stremio/stremio-features#1766

Thanks for your time.

this is already implemented and present in version 5 of stremio go to stremio.com and download the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants