Skip to content

Add missing disabled submit button styles to Lite #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Jun 23, 2026
Merged

Add missing disabled submit button styles to Lite #3168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions css/_single_theme.css.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,12 @@
<?php if ( $submit_width !== 'auto' ) { ?>
max-width:var(--submit-width)<?php echo esc_html( $important ); ?>;
<?php } ?>
}
.<?php echo esc_html( $style_class ); ?> input[type=submit][disabled],

@deepsource-io deepsource-io Bot Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style_class might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

.<?php echo esc_html( $style_class ); ?> .frm_submit input[type=button][disabled],

@deepsource-io deepsource-io Bot Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style_class might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

.<?php echo esc_html( $style_class ); ?> .frm_submit button[disabled] {

@deepsource-io deepsource-io Bot Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable $style_class might not be defined


A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Comment on lines +318 to +320

@coderabbitai coderabbitai Bot Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Disabled button selector misses non-.frm_submit submit buttons.

classes/views/frm-forms/form.php renders a disabled <button class="frm_button_submit" disabled="disabled"> that is not shown inside .frm_submit, so this rule set may not apply to that Lite submit button case. Add a selector that targets disabled submit buttons directly (e.g., button[type=submit][disabled] and/or .frm_button_submit[disabled]) under the style class.

Suggested selector adjustment 
 .<?php echo esc_html( $style_class ); ?> input[type=submit][disabled],
 .<?php echo esc_html( $style_class ); ?> .frm_submit input[type=button][disabled],
-.<?php echo esc_html( $style_class ); ?> .frm_submit button[disabled] {
+.<?php echo esc_html( $style_class ); ?> .frm_submit button[disabled],
+.<?php echo esc_html( $style_class ); ?> button[type=submit][disabled],
+.<?php echo esc_html( $style_class ); ?> .frm_button_submit[disabled] {
 	opacity: 0.5;
 	cursor: not-allowed;
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.<?php echo esc_html( $style_class ); ?> input[type=submit][disabled],
.<?php echo esc_html( $style_class ); ?> .frm_submit input[type=button][disabled],
.<?php echo esc_html( $style_class ); ?> .frm_submit button[disabled] {
.<?php echo esc_html( $style_class ); ?> input[type=submit][disabled],
.<?php echo esc_html( $style_class ); ?> .frm_submit input[type=button][disabled],
.<?php echo esc_html( $style_class ); ?> .frm_submit button[disabled],
.<?php echo esc_html( $style_class ); ?> button[type=submit][disabled],
.<?php echo esc_html( $style_class ); ?> .frm_button_submit[disabled] {
opacity: 0.5;
cursor: not-allowed;
}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@css/_single_theme.css.php` around lines 318 - 320, The CSS selector rule in
the disabled button styling block is incomplete and misses disabled submit
buttons that are rendered outside the `.frm_submit` container. Add additional
selectors to the existing rule targeting disabled buttons directly. Include
selectors for `button[type=submit][disabled]` to catch submit button elements
with the disabled attribute, and `.frm_button_submit[disabled]` to catch
disabled buttons with the frm_button_submit class. These new selectors should be
added alongside the existing ones under the same style class wrapper so that all
disabled button variations across the form are properly styled.

opacity: 0.5;
cursor: not-allowed;
}
<?php
}//end if
Expand Down
Loading