Remove cross sell

[Crabcyborg]

These aren't in use, and it sounds like we're moving in a different direction with our cross sells that won't require for them to be dynamic links.

Summary by CodeRabbit

• Bug Fixes
  • Removed the cross-sell admin menu feature from the plugin.

[coderabbitai]

📝 Walkthrough

Walkthrough

The cross-sell feature is fully removed: FrmSalesApi loses its static cross-sell text/link properties, the sales-data parsing branch that called set_cross_sell(), and the public static menu() method. The corresponding admin_menu hook registration in FrmHooksController::load_admin_hooks() is also deleted.

Changes

Cross-sell feature removal

Layer / File(s)	Summary
FrmSalesApi cross-sell data and menu removal classes/models/FrmSalesApi.php	Removes static properties for cross-sell text/link, the set_sales() branch that detected and applied cross-sell data, and the public static menu() method that registered the admin submenu and redirected on admin_init.
admin_menu hook deregistration classes/controllers/FrmHooksController.php	Removes the add_action( 'admin_menu', 'FrmSalesApi::menu', 1000 ) call from load_admin_hooks(), so no cross-sell submenu is injected during admin setup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐇 Hop hop, the cross-sell's gone away,
No sneaky menu to lead astray.
The admin panel breathes with ease,
No redirects hiding in the trees.
Clean code naps in a tidy warren today! 🌿

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Remove cross sell' directly and clearly describes the main change—removing cross-sell functionality from the codebase across multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove_cross_sell

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[deepsource-io]

DeepSource Code Review

We reviewed changes in 78f05b9...096383b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade

Security   Reliability   Complexity   Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Jun 18, 2026 4:53p.m.	Review ↗
JavaScript		Jun 18, 2026 4:53p.m.	Review ↗

---

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.