Skip to content

Stop showing safari autofill for autocomplete off payment settings in…#3158

Merged
Crabcyborg merged 3 commits into
masterfrom
stop_showing_safari_autofill_for_autocomplete_off_payment_settings_inputs
Jun 18, 2026
Merged

Stop showing safari autofill for autocomplete off payment settings in…#3158
Crabcyborg merged 3 commits into
masterfrom
stop_showing_safari_autofill_for_autocomplete_off_payment_settings_inputs

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

…puts

Related ticket https://secure.helpscout.net/conversation/3359646866/253809

The issue is that Safari will add the autofill if anything includes the word "Email". This includes id, name, and label. It also ignores autocomplete attributes.

The suggestion in https://stackoverflow.com/questions/43058018/how-to-disable-autocomplete-in-address-fields-for-safari to use ‌ also appears to no longer work.

So this update uses some CSS to forcibly hide the elements that Safari adds if an input has email somewhere in the name attribute.

Pre-release
formidable-6.32.1b.zip

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved payment settings form by preventing browser autofill suggestions from interfering with payment input fields, providing a cleaner checkout experience.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The payment settings email input field gains autocomplete="off". A companion SCSS rule suppresses Safari's ::-webkit-contacts-auto-fill-button pseudo-element on inputs with autocomplete="off" inside .frm_single_payment_settings via visibility: hidden, display: none !important, and pointer-events: none.

Changes

Disable autofill on payment email input

Layer / File(s) Summary
Email input autocomplete and Safari button suppression
stripe/views/action-settings/payments-options.php, resources/scss/admin/components/settings/_global-payment-settings.scss
The email <input> adds autocomplete="off", and a new SCSS rule hides the Safari ::-webkit-contacts-auto-fill-button pseudo-element on inputs with that attribute inside .frm_single_payment_settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Hop hop, no Safari pop!
The bunny hid the autofill dot,
With display: none and pointer gone,
The email field stands neat and strong,
No ghost addresses carry on! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly corresponds to the main change: hiding Safari's autofill suggestions for payment settings fields with autocomplete='off' attribute.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stop_showing_safari_autofill_for_autocomplete_off_payment_settings_inputs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io

deepsource-io Bot commented Jun 18, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in f15c192...d5ac226 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jun 18, 2026 3:13p.m. Review ↗
JavaScript Jun 18, 2026 3:13p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Crabcyborg
Crabcyborg merged commit 78f05b9 into master Jun 18, 2026
22 checks passed
@Crabcyborg
Crabcyborg deleted the stop_showing_safari_autofill_for_autocomplete_off_payment_settings_inputs branch June 18, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant