Skip to content

Prepare for 6.32#3150

Merged
Crabcyborg merged 6 commits into
masterfrom
prepare_for_6.32
Jun 16, 2026
Merged

Prepare for 6.32#3150
Crabcyborg merged 6 commits into
masterfrom
prepare_for_6.32

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes - Version 6.32

  • New Features

    • Enhanced form listing table with additional columns and screen options
    • Generated CSS now delivered from the uploads directory
  • Improvements

    • Field error removal optimized for change events
    • Accessibility attribute enhancements for improved ARIA support
  • Bug Fixes

    • Resolved HTML overflow styling issues
    • Fixed color picker format handling
    • Corrected Square postal code validation behavior
    • Fixed custom CSS duplication
    • Resolved UTF-8 validation errors
    • Corrected PayPal payment description handling
    • Improved subscription logging behavior

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Crabcyborg, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 8 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a60c77b8-0e3a-4f58-b239-1bee2491969c

📥 Commits

Reviewing files that changed from the base of the PR and between c43ee95 and ff0a502.

📒 Files selected for processing (1)
  • denylist/splorp-wp-comment.txt
📝 Walkthrough

Walkthrough

Version bump from 6.31 to 6.32: the plugin version constant, plugin header, readme stable tag, and POT header are updated. All placeholder @since x.x docblock annotations across PHP controllers, helpers, models, views, and JS files are replaced with 6.32. The POT file is regenerated and changelog entries are added to both changelog.txt and readme.txt.

Changes

Formidable Forms 6.32 Release Preparation

Layer / File(s) Summary
Plugin version and release metadata
formidable.php, classes/helpers/FrmAppHelper.php, readme.txt, changelog.txt, languages/formidable.pot
FrmAppHelper::$plug_version and the plugin header bumped from 6.31 to 6.32; readme stable tag updated; new 6.32 changelog section added to both changelog.txt and readme.txt; POT header refreshed.
PHP @since annotation updates
classes/controllers/Frm*Controller.php, classes/helpers/Frm*Helper.php, classes/models/FrmStyle*.php, classes/models/fields/FrmFieldType.php, classes/views/frm-forms/*, classes/views/styles/*, stripe/models/FrmTransLiteSubscription.php
Placeholder @since x.x annotations replaced with 6.32 across all PHP controllers, helpers, models, and view templates. One @deprecated x.x and one _doing_it_wrong version string in FrmFormsListHelper also updated to 6.32.
JavaScript @since annotation updates
js/admin/forms-list.js, js/formidable.js, js/src/admin/admin.js, js/src/admin/settings/utils.js, js/src/admin/settings/validateField.js, js/src/admin/settings/validateRangeSettings.js
JSDoc @since x.x placeholders replaced with 6.32 for syncModeToUrl, validateField, removeElementFromInputDescribedBy, getFieldId, getFieldType, focusFieldOnModalDismiss, and range-settings validation functions.
POT translation file regeneration
languages/formidable.pot
POT regenerated for 6.32 with new and updated msgid entries covering forms list UI, styles management, field groups, PayPal Lite validation errors, embed locations, checkbox/radio layout options, and admin action strings; source-file references updated throughout.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • garretlaxton

🐇 Hop, hop, hooray, it's version six-thirty-two!
@since x.x is gone, replaced with something true.
The changelog is written, the POT file reborn,
Each docblock now gleaming, no placeholder worn.
🎉 The rabbit stamps "6.32" with a flourish and flair!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Prepare for 6.32' accurately describes the main purpose of the changeset, which is a version bump from 6.31 to 6.32 across documentation, configuration files, and code annotations.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch prepare_for_6.32

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io

deepsource-io Bot commented Jun 16, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in d51b719...ff0a502 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jun 16, 2026 3:19p.m. Review ↗
JavaScript Jun 16, 2026 3:19p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
classes/models/fields/FrmFieldType.php (1)

1602-1609: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Keep the privacy note aligned with the signature.

The docblock on Line 1602 says this method changed from protected to public, but the declaration on Line 1609 is still protected. Please update one side or the other so the docs don’t misstate the API.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@classes/models/fields/FrmFieldType.php` around lines 1602 - 1609, The
docblock for the add_aria_description method states that its privacy changed
from protected to public in version 6.32, but the method signature on line 1609
is still declared as protected. Update the method signature to public to align
with the documented privacy change, ensuring the actual code matches the
declared API contract.
classes/controllers/FrmFieldsController.php (1)

1602-1609: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Keep the privacy note in sync with the signature.

The docblock on Line 1602 says this method changed from protected to public, but the declaration on Line 1609 is still protected. Either update the signature or drop the privacy-change note.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@classes/controllers/FrmFieldsController.php` around lines 1602 - 1609, The
docblock on the method declaration in FrmFieldsController.php contains a note
indicating the method changed from protected to public, but the actual method
signature on line 1609 remains protected. Either update the method signature to
public to match the documented change, or remove the privacy-change note from
the docblock to accurately reflect that the method is still protected. Ensure
the docblock and the actual method visibility modifier are consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@classes/controllers/FrmFieldsController.php`:
- Around line 1602-1609: The docblock on the method declaration in
FrmFieldsController.php contains a note indicating the method changed from
protected to public, but the actual method signature on line 1609 remains
protected. Either update the method signature to public to match the documented
change, or remove the privacy-change note from the docblock to accurately
reflect that the method is still protected. Ensure the docblock and the actual
method visibility modifier are consistent.

In `@classes/models/fields/FrmFieldType.php`:
- Around line 1602-1609: The docblock for the add_aria_description method states
that its privacy changed from protected to public in version 6.32, but the
method signature on line 1609 is still declared as protected. Update the method
signature to public to align with the documented privacy change, ensuring the
actual code matches the declared API contract.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 22e5b4a9-deb1-4c87-a41e-5d0a8879a585

📥 Commits

Reviewing files that changed from the base of the PR and between d51b719 and c43ee95.

⛔ Files ignored due to path filters (2)
  • js/formidable.min.js is excluded by !**/*.min.js
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (24)
  • changelog.txt
  • classes/controllers/FrmFieldsController.php
  • classes/controllers/FrmFormsController.php
  • classes/controllers/FrmStylesController.php
  • classes/helpers/FrmAppHelper.php
  • classes/helpers/FrmFormsListHelper.php
  • classes/helpers/FrmStylesHelper.php
  • classes/helpers/FrmStylesPreviewHelper.php
  • classes/models/FrmSalesApi.php
  • classes/models/FrmStyle.php
  • classes/models/fields/FrmFieldType.php
  • classes/views/frm-forms/add_field.php
  • classes/views/frm-forms/forms-list-settings.php
  • classes/views/styles/_check-box-radio-fields.php
  • formidable.php
  • js/admin/forms-list.js
  • js/formidable.js
  • js/src/admin/admin.js
  • js/src/admin/settings/utils.js
  • js/src/admin/settings/validateField.js
  • js/src/admin/settings/validateRangeSettings.js
  • languages/formidable.pot
  • readme.txt
  • stripe/models/FrmTransLiteSubscription.php

@Crabcyborg
Crabcyborg merged commit a0afae2 into master Jun 16, 2026
21 of 22 checks passed
@Crabcyborg
Crabcyborg deleted the prepare_for_6.32 branch June 16, 2026 16:13
@coderabbitai coderabbitai Bot mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant