Skip to content

Pass action descriptions to paypal#3145

Merged
Crabcyborg merged 1 commit into
masterfrom
pass_action_description_to_paypal
Jun 12, 2026
Merged

Pass action descriptions to paypal#3145
Crabcyborg merged 1 commit into
masterfrom
pass_action_description_to_paypal

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request adds description field support to PayPal Lite payment and subscription creation. The controller now processes action description shortcodes for both orders and subscriptions, while the create_order() helper method signature is extended to accept and forward descriptions to the PayPal API.

Changes

PayPal Description Integration

Layer / File(s) Summary
Helper signature extension for descriptions
paypal/helpers/FrmPayPalLiteConnectHelper.php
create_order() method signature extended with optional $description parameter; description is included in the post_with_authenticated_body('create_order', ...) payload sent to the Connect server.
Order creation with description
paypal/controllers/FrmPayPalLiteAppController.php
Order creation computes $description by processing action description shortcodes and passes it to the updated create_order() helper method.
Subscription creation with description
paypal/controllers/FrmPayPalLiteAppController.php
Subscription creation computes $description from action description (via shortcode processing) and includes it in the $data array sent to create_subscription().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 From fields of forms, descriptions now flow,
Through PayPal's lanes, on orders they go,
Shortcodes processed with careful delight,
Each subscription and payment—now right!
With descriptions added, the feature's complete,
A rabbit's small change makes the merge oh so sweet.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: passing action descriptions to PayPal, which is directly reflected in both modified files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pass_action_description_to_paypal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io

deepsource-io Bot commented Jun 12, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in d415c02...1736f06 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jun 12, 2026 1:22p.m. Review ↗
JavaScript Jun 12, 2026 1:22p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Crabcyborg
Crabcyborg merged commit c2467d2 into master Jun 12, 2026
47 of 48 checks passed
@Crabcyborg
Crabcyborg deleted the pass_action_description_to_paypal branch June 12, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant