Address feedback and refactor Windsurf rules for Formidable patterns#2960
Merged
Crabcyborg merged 63 commits intoFeb 20, 2026
Merged
Conversation
…backslash-accumulation
…en-behind-panel Fix field options dropdown hidden behind panel
…rkflow Include scss in stylelint workflow
Add stylelint workflow and baseline
…sh-accumulation Fix backslash accumulation in Stripe and Square settings
…ta_cleanup Add object check to usage data cleanup
…ange principles Add requirement to use Big-O notation for comparing algorithms and selecting most efficient option for large inputs and iterations in Phase 3 (Change Execution) of code-change-principles.md
…guide Change scope list from dash-space to colon format for consistency with conventional commits examples. Remove redundant instruction about issue references that duplicates earlier section.
…nciples Add "comments" to list of text types covered by writing style guidelines (PR titles, PR body, commit messages, etc.) to clarify that code comments should follow the same style rules.
Change property group labels from dash to colon format for consistency with other documentation formatting (Display and Box Model - to Display and Box Model:, etc.)
…patterns documentation Add comprehensive JavaScript coding standards for Formidable Forms including modern ES6+ patterns, DOM manipulation with frmDom helpers, async/await patterns, error handling, performance optimization, and architectural decisions. Document critical rules: no jQuery in new code, prefer functional over class-based, use ES modules except admin.js. Include frmDom.util event helpers, template system patterns, state
…from dash to colon Change Arrange-Act-Assert pattern comments and assertion examples from dash-space to colon format for consistency with other documentation (// Arrange - to // Arrange:, // CORRECT - to // CORRECT:, etc.). Rename testing.md to frm-testing.md to follow formidable file naming convention.
…ress polyfills in frm-php.md Remove return type declarations from PHP 7.0 allowed features (moved to 7.1+ forbidden list). Update minimum WordPress version from 5.5 to 6.3. Add WordPress-polyfilled functions table showing str_contains/str_starts_with/str_ends_with are safe to use, while array_is_list and newer array functions require version checks. Clarify Lite subfolder classes use Frm prefix. Update Pro hook naming rule to only
…s documentation Add comprehensive React coding standards for Formidable Forms including functional components with hooks, memoization patterns, state management, composition patterns, and WordPress data layer integration. Document critical rules: functional components only (no classes), import hooks from @wordpress/element, use WordPress packages for i18n/API/components/data. Include useMemo/useCallback optimization patterns, derived
…ctions documentation Add comprehensive security guidelines for Formidable Forms including input handling with FrmAppHelper sanitization functions (get_post_param/simple_get/get_param), nonce verification patterns, safe serialization using maybe_unserialize_array, DOM sanitization with frmDom.cleanNode, authorization checks with current_user_can/permission_nonce_error/user_has_permission, and Formidable capabilities reference table
Use eslint 9
…corn_rule Apply no typeof undefined unicorn rule
…ject_shorthand New eslint rule to prefer object shorthand
Crabcyborg
approved these changes
Feb 20, 2026
Crabcyborg
left a comment
Crabcyborg
left a comment
Contributor
There was a problem hiding this comment.
Thanks @shervElmi!
I've merged a PR into this because it includes a new skill for adding ES Lint rules.
We also now have the 4 new rules I demoed today in the meeting.
I'll go ahead and merge this so everything in is one one PR.
Crabcyborg
merged commit Feb 20, 2026
349ca42
into
feature/windsurf-configuration-formidable
34 of 39 checks passed
stephywells
pushed a commit
that referenced
this pull request
Apr 4, 2026
…rf-rules Address feedback and refactor Windsurf rules for Formidable patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base PR