Rock: Redesigned forms list

classes/controllers/FrmAppController.php

@@ -729,9 +729,20 @@ public static function admin_js() {
 
 		wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', self::get_admin_js_dependencies(), $version, true );
 
+		wp_register_script(
+			'formidable_forms_list',
+			$plugin_url . '/js/admin/forms-list.js',
+			array(
+				'formidable_dom',
+			),
+			$version,
+			true
+		);
+
 		if ( FrmAppHelper::on_form_listing_page() ) {
 			// For the existing page dropdown in the Form embed modal.
 			wp_enqueue_script( 'jquery-ui-autocomplete' );
+			wp_enqueue_script( 'formidable_forms_list' );
 		}
 
 		wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '2.0', true );

classes/controllers/FrmFormsController.php

@@ -48,6 +48,13 @@
 		add_filter( 'manage_toplevel_page_formidable_sortable_columns', 'FrmFormsController::get_sortable_columns' );
 	}
 
+	/**
+	 * Runs on admin head of the formidable forms page.
+	 *
+	 * @since x.x This adds screen options.
+	 *
+	 * @return void
+	 */
 	public static function head() {
 		if ( wp_is_mobile() ) {
 			wp_enqueue_script( 'jquery-touch-punch' );
@@ -1233,15 +1240,25 @@
 		$columns['cb']       = '<input type="checkbox" />';
 		$columns['name']     = esc_html__( 'Form Title', 'formidable' );
 		$columns['entries']  = esc_html__( 'Entries', 'formidable' );
+		$columns['views']    = esc_html__( 'Views', 'formidable' );
 		$columns['id']       = 'ID';
 		$columns['form_key'] = esc_html__( 'Key', 'formidable' );
 
-		if ( 'trash' !== FrmAppHelper::simple_get( 'form_type' ) ) {
+		if ( 'trash' !== FrmAppHelper::simple_get( 'form_type' ) && has_filter( 'frm_form_list_actions' ) ) {
+			// If there is any filters added, keep this column.
 			$columns['shortcode'] = esc_html__( 'Actions', 'formidable' );
 		}
 
 		$columns['created_at'] = esc_html__( 'Date', 'formidable' );
 
+		if ( 'trash' !== FrmAppHelper::simple_get( 'form_type' ) ) {
+			$columns['embeds']    = esc_html__( 'Embeds', 'formidable' );
+			$columns['settings']  = '<div class="frm-forms-list-settings-btn-wrapper"><a href="#" class="frm-forms-list-settings-btn">';
+			$columns['settings'] .= FrmAppHelper::icon_by_class( 'frmfont frm_settings_icon', array( 'echo' => false ) );
+			$columns['settings'] .= '<span class="screen-reader-text">' . esc_html__( 'List settings', 'formidable' ) . '</span>';
+			$columns['settings'] .= '</a></div>';
+		}
+
 		add_screen_option(
 			'per_page',
 			array(
@@ -1381,7 +1398,7 @@
 		 * @param object[] $fields Array of fields.
 		 * @param array    $args   The arguments. Contains `form`.
 		 */
 		$values['fields'] = apply_filters( 'frm_fields_in_form_builder', $fields, compact( 'form' ) );
 
 		$edit_message = __( 'Form was successfully updated.', 'formidable' );
 
@@ -1463,7 +1480,7 @@
 		 * @param array $fields Array of fields.
 		 * @param array $args   The arguments. Contains `form`.
 		 */
 		$values['fields'] = apply_filters( 'frm_fields_in_settings', $values['fields'], compact( 'form' ) );
 
 		self::clean_submit_html( $values );
 
@@ -3696,6 +3713,37 @@
 		);
 	}
 
+	/**
+	 * Prints necessary templates for the forms list page.
+	 *
+	 * @since x.x
+	 *
+	 * @return void
+	 */
+	public static function print_forms_list_templates() {
+		if ( ! FrmAppHelper::on_form_listing_page() ) {
+			return;
+		}
+
+		$screen = get_current_screen();
+
+		if ( ! $screen ) {
+			return;
+		}
+
+		$columns             = get_column_headers( $screen );
+		$hidden              = get_hidden_columns( $screen );
+		$skip_cols           = array( 'cb', 'name', 'settings' );
+		$per_page            = get_user_option( 'formidable_page_formidable_per_page' );
+		$show_screen_options = $screen->show_screen_options();
+
+		if ( $per_page < 1 ) {
+			$per_page = 20;
+		}
+
+		include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/forms-list-settings.php';
+	}
+
 	/**
 	 * @deprecated 4.0
 	 *

classes/controllers/FrmHooksController.php

@@ -85,6 +85,9 @@ public static function load_hooks() {
 
 		add_action( 'wp_scheduled_delete', 'FrmForm::scheduled_delete' );
 
+		// Clear embed posts transient when posts are updated.
+		add_action( 'wp_insert_post', 'FrmFormsListHelper::maybe_clear_embed_posts_transient', 10, 2 );
+
 		// Form Shortcodes.
 		add_shortcode( 'formidable', 'FrmFormsController::get_form_shortcode' );
 
@@ -159,6 +162,7 @@ public static function load_admin_hooks() {
 
 		add_filter( 'set-screen-option', 'FrmFormsController::save_per_page', 10, 3 );
 		add_action( 'admin_footer', 'FrmFormsController::insert_form_popup' );
+		add_action( 'admin_footer', 'FrmFormsController::print_forms_list_templates' );
 
 		// Elementor.
 		add_action( 'elementor/editor/footer', 'FrmElementorController::admin_init' );

classes/helpers/FrmAppHelper.php

@@ -1536,6 +1536,8 @@ public static function array_to_html_params( $atts, $echo = false ) {
 	 * @param bool    $echo
 	 *
 	 * @return string|null
+	 *
+	 * @psalm-return ($echo is true ? null : string)
 	 */
 	public static function clip( $echo_function, $echo = false ) {
 		if ( ! $echo ) {

classes/helpers/FrmEntriesListHelper.php

@@ -364,7 +364,7 @@ public function single_row( $item, $style = '' ) {
 			}
 
 			if ( in_array( $column_name, $hidden, true ) ) {
-				$class .= ' frm_hidden';
+				$class .= ' hidden';
 			} elseif ( ! $action_col && ! in_array( $column_name, $action_columns, true ) ) {
 				$action_col = $column_name;
 			}

classes/helpers/FrmFormsHelper.php

@@ -1248,7 +1248,7 @@ public static function get_action_links( $form_id, $form ) {
 			} else {
 				$actions['duplicate'] = array(
 					'url'   => wp_nonce_url( $duplicate_link ),
-					'label' => __( 'Duplicate Form', 'formidable' ),
+					'label' => __( 'Duplicate', 'formidable' ),
 					'icon'  => 'frmfont frm_clone_icon',
 				);
 			}