Skip to content

Include tooltip_icon as a preferred FrmAppHelper function#2892

Merged
Crabcyborg merged 1 commit into
masterfrom
include_tooltip_icon_as_preferred_frmapphelper_function
Jan 27, 2026
Merged

Include tooltip_icon as a preferred FrmAppHelper function#2892
Crabcyborg merged 1 commit into
masterfrom
include_tooltip_icon_as_preferred_frmapphelper_function

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Chores

  • Updated code analysis tool to detect additional method patterns during development code reviews.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Added 'tooltip_icon' to the private $methods list in PreferFrmAppHelperSniff.php, expanding the set of FrmProAppHelper methods that the sniff detects for replacement with FrmAppHelper equivalents.

Changes

Cohort / File(s) Summary
PHP_CodeSniffer Method List Update
phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/PreferFrmAppHelperSniff.php
Added 'tooltip_icon' to the private $methods array, enabling the sniff to flag FrmProAppHelper::tooltip_icon calls for replacement with FrmAppHelper equivalents.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A method joins the sniffing crew,
tooltip_icon, shiny and new,
No more FrmProAppHelper calls in sight,
The sniff catches them—all is right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: adding 'tooltip_icon' to the preferred FrmAppHelper methods list in the code sniff.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg
Crabcyborg merged commit 0b6dcbd into master Jan 27, 2026
38 checks passed
@Crabcyborg
Crabcyborg deleted the include_tooltip_icon_as_preferred_frmapphelper_function branch January 27, 2026 15:44
stephywells pushed a commit that referenced this pull request Apr 4, 2026
…erred_frmapphelper_function

Include tooltip_icon as a preferred FrmAppHelper function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant