Replace phpcs exceptions with phpcs disable comments wrapped around i…#2882
Merged
Crabcyborg merged 13 commits intoJan 26, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR primarily adds PHP_CodeSniffer indentation suppression/restore comments around many HTML/PHP output blocks and adjusts phpcs.xml ScopeIndent excludes. One controller (FrmFormsController::insert_form_popup) conditionally initializes and renders the WP editor when needed. Changes
Sequence Diagram(s)(Skipped — changes are largely PHPCS directive additions and small conditional editor initialization not warranting a sequence diagram.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@phpcs.xml`:
- Around line 241-256: The global phpcs ScopeIndent excludes list contains
redundant entries and missing inline suppressions: add targeted inline disables
(phpcs:disable Generic.WhiteSpace.ScopeIndent ... phpcs:enable) in the five
files that currently lack them—classes/models/FrmFieldTextarea.php,
classes/models/FrmEntryMeta.php, classes/controllers/FrmFieldsController.php,
classes/models/FrmPluginSearch.php, and
stripe/helpers/FrmTransLiteListHelper.php—and then remove the now-redundant
<exclude-pattern> entries for the seven files that already include inline
suppressions (classes/helpers/FrmStylesCardHelper.php,
classes/helpers/FrmFormsListHelper.php,
stripe/helpers/FrmTransLiteAppHelper.php, classes/helpers/FrmStylesHelper.php,
classes/models/FrmSolution.php, classes/controllers/FrmFormsController.php,
classes/helpers/FrmFormsHelper.php) from phpcs.xml so the project relies on
file-local suppressions only.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@classes/helpers/FrmAppHelper.php`:
- Around line 855-857: The phpcs suppression comment above the $_REQUEST access
is duplicated ("phpcs:ignore phpcs:ignore ...") so the sniff suppression may not
work; edit the comment in the FrmAppHelper code block that contains the
isset($_REQUEST[$args['param']]) check and the $value = wp_unslash(...) line to
use a single phpcs:ignore token—e.g. change it to "// phpcs:ignore
WordPress.Security.NonceVerification.Missing,
WordPress.Security.ValidatedSanitizedInput.InputNotSanitized" (or use a single
appropriate phpcs directive) so the intended sniffs are properly suppressed.
Crabcyborg
deleted the
replace_phpcs_exceptions_with_phpcs_disable_comments
branch
January 26, 2026 18:16
stephywells
pushed a commit
that referenced
this pull request
Apr 4, 2026
…h_phpcs_disable_comments Replace phpcs exceptions with phpcs disable comments wrapped around i…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nline HTML
This way we're not ignoring indentation issues in some of these large files.
Summary by CodeRabbit
Style
Chores
New Features
✏️ Tip: You can customize this high-level summary in your review settings.