Skip to content

New sniff to make type comments more accurate #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 6 commits into from
Jan 23, 2026
Merged

New sniff to make type comments more accurate #2870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc8b96a
New sniff to make type comments more accurate
Crabcyborg Jan 23, 2026
ef6b6a9
Add some more exceptions and revert some changes
Crabcyborg Jan 23, 2026
dd9520a
Revert another change
Crabcyborg Jan 23, 2026
447e1c1
Revert another change
Crabcyborg Jan 23, 2026
07e70d3
Run php cs fixer
Crabcyborg Jan 23, 2026
128662f
Revert another change and ignore callable
Crabcyborg Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions classes/controllers/FrmFieldsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,9 @@ public static function get_field_array_from_id( $field_id ) {
/**
* @since 3.0
*
* @param array|int|object $field_object
* @param array $values
* @param int $form_id
* @param array|int|object|string $field_object
* @param array $values
* @param int $form_id
*
* @return void
*/
Expand Down
2 changes: 1 addition & 1 deletion classes/controllers/FrmFormActionsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ public static function trigger_create_actions( $entry_id, $form_id, $args = arra
/**
* @param string $event
* @param int|object|string $form
* @param int|string $entry
* @param int|object|string $entry
* @param string $type
Comment thread
coderabbitai[bot] marked this conversation as resolved.
* @param array $args
*
Expand Down
6 changes: 3 additions & 3 deletions classes/controllers/FrmFormsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3394,9 +3394,9 @@ private static function show_lone_success_message( $atts ) {
* @since 2.05
* @since 6.0.x Added the third parameter.
*
* @param object $form Form object.
* @param int $entry_id Entry ID.
* @param array $args See {@see FrmFormsController::run_success_action()}.
* @param object $form Form object.
* @param int|string $entry_id Entry ID.
* @param array $args See {@see FrmFormsController::run_success_action()}.
*
* @return string
*/
Expand Down
2 changes: 1 addition & 1 deletion classes/helpers/FrmAppHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2432,7 +2432,7 @@ public static function checked( $values, $current ) {

/**
* @param array|string $values
* @param string $current
* @param string|null $current
*
* @return bool
*/
Expand Down
6 changes: 3 additions & 3 deletions classes/helpers/FrmEntriesHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,9 @@ private static function set_parent_field_posted_value( $field, $value, $args ) {
}

/**
* @param array|int|object $field
* @param mixed $value
* @param array $args
* @param array|int|object|string $field
* @param mixed $value
* @param array $args
*
* @return void
*/
Expand Down
2 changes: 1 addition & 1 deletion classes/models/FrmEntry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ public static function get_new_entry_name( $values, $default = '' ) {
*
* @since 2.0.9
*
* @param int|object $entry By reference.
* @param int|object|string $entry By reference.
*
* @return void
*/
Expand Down
6 changes: 3 additions & 3 deletions classes/models/FrmForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,8 +605,8 @@ public static function translatable_strings( $form ) {
}

/**
* @param int $id
* @param string $status
* @param array|int $id
* @param string $status
*
* @return bool|int
*/
Expand Down Expand Up @@ -837,7 +837,7 @@ public static function get_key_by_id( $id ) {
*
* @since 2.0.9
*
* @param int|object $form
* @param array|int|object $form
*
* @return void
*/
Expand Down
4 changes: 2 additions & 2 deletions classes/models/FrmFormAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,8 +666,8 @@ public static function get_action_limit( $form_id, $limit = 99 ) {
/**
* @since 3.04
*
* @param array $args
* @param string $default_status
* @param array|string $args
* @param string $default_status
*
* @return void
*/
Expand Down
Loading