Skip to content

New sniff to add early continue to loops that are just one big if #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 3 commits into from
Jan 15, 2026
Merged

New sniff to add early continue to loops that are just one big if #2804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d28bb4
New sniff to add early continue to loops that are just one big if
Crabcyborg Jan 15, 2026
924ab3a
Merge branch 'new_sniff_to_add_early_returns_to_big_functions_that_ar…
Crabcyborg Jan 15, 2026
9e2ada9
Run php cs fixer
Crabcyborg Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions classes/helpers/FrmEntriesHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,14 +861,17 @@ public static function maybe_render_captcha_score( $entry_id ) {
$metas_without_a_field = (array) FrmEntryMeta::getAll( $query, ' ORDER BY it.created_at DESC', '', true );

foreach ( $metas_without_a_field as $meta ) {
if ( ! empty( $meta->meta_value['captcha_score'] ) ) {
echo '<div class="misc-pub-section">';
FrmAppHelper::icon_by_class( 'frmfont frm_shield_check_icon', array( 'aria-hidden' => 'true' ) );
echo ' ' . esc_html__( 'reCAPTCHA Score', 'formidable' ) . ': ';
echo '<b>' . esc_html( $meta->meta_value['captcha_score'] ) . '</b>';
echo '</div>';
return;
if ( empty( $meta->meta_value['captcha_score'] ) ) {
continue;
}

echo '<div class="misc-pub-section">';
FrmAppHelper::icon_by_class( 'frmfont frm_shield_check_icon', array( 'aria-hidden' => 'true' ) );
echo ' ' . esc_html__( 'reCAPTCHA Score', 'formidable' ) . ': ';
echo '<b>' . esc_html( $meta->meta_value['captcha_score'] ) . '</b>';
echo '</div>';
return;

}
}

Expand Down
31 changes: 17 additions & 14 deletions classes/views/shared/form-nav.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,24 @@
<?php

foreach ( $nav_items as $nav_item ) {
if ( current_user_can( $nav_item['permission'] ) ) {
?>
<li>
<a href="<?php echo esc_url( $nav_item['link'] ); ?>"
<?php FrmAppHelper::select_current_page( $nav_item['page'], $current_page, $nav_item['current'] ); ?>
<?php
if ( isset( $nav_item['atts'] ) ) {
FrmAppHelper::array_to_html_params( $nav_item['atts'], true );
}
?>>
<?php echo esc_html( $nav_item['label'] ); ?>
</a>
</li>
<?php
if ( ! current_user_can( $nav_item['permission'] ) ) {
continue;
}

?>
<li>
<a href="<?php echo esc_url( $nav_item['link'] ); ?>"
<?php FrmAppHelper::select_current_page( $nav_item['page'], $current_page, $nav_item['current'] ); ?>
<?php
if ( isset( $nav_item['atts'] ) ) {
FrmAppHelper::array_to_html_params( $nav_item['atts'], true );
}
?>>
<?php echo esc_html( $nav_item['label'] ); ?>
</a>
</li>
<?php

}
?>
</ul>
Loading
Loading