Skip to content

Move formidable sniffs to separate ruleset file #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Jan 14, 2026
Merged

Move formidable sniffs to separate ruleset file #2801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions phpcs-sniffs/Formidable/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,35 @@
<?xml version="1.0"?>
<ruleset name="Formidable">
<description>Custom sniffs for Formidable Forms</description>

<!-- Whitespace -->
<rule ref="Formidable.WhiteSpace.BlankLineAfterClosingBrace" />
<rule ref="Formidable.WhiteSpace.BlankLineBeforeReturnAfterBrace" />
<rule ref="Formidable.WhiteSpace.ConsecutiveAssignmentSpacing" />
<rule ref="Formidable.WhiteSpace.ShortFunctionBlankLine" />
<rule ref="Formidable.WhiteSpace.NoBlankLineInShortIf" />
<rule ref="Formidable.WhiteSpace.NoBlankLineAfterLoopOpen" />
<rule ref="Formidable.WhiteSpace.NoBlankLineAfterIfOpen" />

<!-- Code Analysis -->
<rule ref="Formidable.CodeAnalysis.SimplifyIfReturn" />
<rule ref="Formidable.CodeAnalysis.SimplifyIssetFalsyCheck" />
<rule ref="Formidable.CodeAnalysis.SimplifyIssetTruthyCheck" />
<rule ref="Formidable.CodeAnalysis.SimplifyIssetEmptyCheck" />
<rule ref="Formidable.CodeAnalysis.SimplifyDualConditionToTernary" />
<rule ref="Formidable.CodeAnalysis.RedundantEmptyOnParameter" />
<rule ref="Formidable.CodeAnalysis.RedundantEmptyOnAssignedVariable" />
<rule ref="Formidable.CodeAnalysis.RedundantParentheses" />
<rule ref="Formidable.CodeAnalysis.RedundantIconEchoArg" />
<rule ref="Formidable.CodeAnalysis.RedundantTruthyBeforeStringComparison" />
<rule ref="Formidable.CodeAnalysis.RedundantIssetBeforeNotEmpty" />
<rule ref="Formidable.CodeAnalysis.RedundantNotIssetBeforeEmpty" />
<rule ref="Formidable.CodeAnalysis.RemoveRedundantWpdbPrefix" />
<rule ref="Formidable.CodeAnalysis.PreferStrictComparison" />
<rule ref="Formidable.CodeAnalysis.PreferStrictInArray" />
<rule ref="Formidable.CodeAnalysis.PreferObGetClean" />
<rule ref="Formidable.CodeAnalysis.PreferKsesEcho" />
<rule ref="Formidable.CodeAnalysis.MoveVariableBelowEarlyReturn" />
<rule ref="Formidable.CodeAnalysis.StrictComparisonForIntFunctions" />
<rule ref="Formidable.CodeAnalysis.FlipNegativeTernary" />
</ruleset>
33 changes: 2 additions & 31 deletions phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,35 +227,6 @@
<type>error</type>
</rule>

<!-- Custom Formidable sniffs -->
<!-- Whitespace -->
<rule ref="Formidable.WhiteSpace.BlankLineAfterClosingBrace" />
<rule ref="Formidable.WhiteSpace.BlankLineBeforeReturnAfterBrace" />
<rule ref="Formidable.WhiteSpace.ConsecutiveAssignmentSpacing" />
<rule ref="Formidable.WhiteSpace.ShortFunctionBlankLine" />
<rule ref="Formidable.WhiteSpace.NoBlankLineInShortIf" />
<rule ref="Formidable.WhiteSpace.NoBlankLineAfterLoopOpen" />
<rule ref="Formidable.WhiteSpace.NoBlankLineAfterIfOpen" />

<!-- Code Analysis -->
<rule ref="Formidable.CodeAnalysis.SimplifyIfReturn" />
<rule ref="Formidable.CodeAnalysis.SimplifyIssetFalsyCheck" />
<rule ref="Formidable.CodeAnalysis.SimplifyIssetTruthyCheck" />
<rule ref="Formidable.CodeAnalysis.SimplifyIssetEmptyCheck" />
<rule ref="Formidable.CodeAnalysis.SimplifyDualConditionToTernary" />
<rule ref="Formidable.CodeAnalysis.RedundantEmptyOnParameter" />
<rule ref="Formidable.CodeAnalysis.RedundantEmptyOnAssignedVariable" />
<rule ref="Formidable.CodeAnalysis.RedundantParentheses" />
<rule ref="Formidable.CodeAnalysis.RedundantIconEchoArg" />
<rule ref="Formidable.CodeAnalysis.RedundantTruthyBeforeStringComparison" />
<rule ref="Formidable.CodeAnalysis.RedundantIssetBeforeNotEmpty" />
<rule ref="Formidable.CodeAnalysis.RedundantNotIssetBeforeEmpty" />
<rule ref="Formidable.CodeAnalysis.RemoveRedundantWpdbPrefix" />
<rule ref="Formidable.CodeAnalysis.PreferStrictComparison" />
<rule ref="Formidable.CodeAnalysis.PreferStrictInArray" />
<rule ref="Formidable.CodeAnalysis.PreferObGetClean" />
<rule ref="Formidable.CodeAnalysis.PreferKsesEcho" />
<rule ref="Formidable.CodeAnalysis.MoveVariableBelowEarlyReturn" />
<rule ref="Formidable.CodeAnalysis.StrictComparisonForIntFunctions" />
<rule ref="Formidable.CodeAnalysis.FlipNegativeTernary" />
<!-- Custom Formidable sniffs (defined in phpcs-sniffs/Formidable/ruleset.xml) -->
<rule ref="Formidable" />
</ruleset>