Skip to content

Change how icons are rendered for inserting shortcodes to reduce numb… #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Jan 12, 2026
Merged

Change how icons are rendered for inserting shortcodes to reduce numb… #2779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions classes/helpers/FrmFormsHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,29 +701,24 @@ public static function insert_opt_html( $args ) {

$truncated_name = FrmAppHelper::truncate( $args['name'], 60 );

if ( isset( $field['icon'] ) ) {
$icon = FrmAppHelper::icon_by_class(
$field['icon'],
array(
'aria-hidden' => 'true',
'echo' => false,
)
);
} else {
$icon = '';
}
?>
<li class="<?php echo esc_attr( $class ); ?>">
<a href="javascript:void(0)" class="frmids frm_insert_code" data-code="<?php echo esc_attr( $args['id'] ); ?>">
<?php
echo FrmAppHelper::kses_icon( $icon ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
if ( isset( $field['icon'] ) ) {
FrmAppHelper::icon_by_class( $field['icon'], array( 'aria-hidden' => 'true' ) );
}

echo esc_html( $truncated_name );
?>
<span>[<?php echo esc_attr( $args['id_label'] ?? $args['id'] ); ?>]</span>
</a>
<a href="javascript:void(0)" class="frmkeys frm_insert_code frm_hidden" data-code="<?php echo esc_attr( $args['key'] ); ?>">
<?php
echo FrmAppHelper::kses_icon( $icon ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
if ( isset( $field['icon'] ) ) {
FrmAppHelper::icon_by_class( $field['icon'], array( 'aria-hidden' => 'true' ) );
}

echo esc_html( $truncated_name );
?>
<span>[<?php echo esc_attr( FrmAppHelper::truncate( $args['key_label'] ?? $args['key'], 7 ) ); ?>]</span>
Expand Down
Loading