Skip to content

Use less old date value in test data#2715

Merged
Crabcyborg merged 1 commit into
masterfrom
use_less_old_date_value_in_test_data
Jan 6, 2026
Merged

Use less old date value in test data#2715
Crabcyborg merged 1 commit into
masterfrom
use_less_old_date_value_in_test_data

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

This looks like it's causing issues in our Pro tests, since this is now past the 10 year cutoff.

@coderabbitai

coderabbitai Bot commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Updates the default date value in the entry field value generator from '2015-01-01' to '2026-01-01'. This is a test data constant update affecting date field test data generation without changes to function signatures or control flow.

Changes

Cohort / File(s) Summary
Test data constant update
tests/phpunit/base/frm_factory.php
Updated default date value for entry field value generator from '2015-01-01' to '2026-01-01'

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, but the title and code changes are clear enough to understand the intent. Consider adding a brief description explaining why the date was updated (e.g., to keep test data current or fix year-dependent tests).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating a date value in test data from an older date to a more recent one.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2b9d35 and d320f3c.

📒 Files selected for processing (1)
  • tests/phpunit/base/frm_factory.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: PHP 7.4 tests in WP 6.9
  • GitHub Check: PHP 8 tests in WP 6.9
  • GitHub Check: PHP 7.4 tests in WP 6.9
  • GitHub Check: PHP 8 tests in WP 6.9
  • GitHub Check: Cypress
  • GitHub Check: Cypress
🔇 Additional comments (1)
tests/phpunit/base/frm_factory.php (1)

144-144: No action required. The date update is safe and has no impact on existing tests.

Verification confirms that no tests reference the old date value '2015-01-01' or depend on the date being approximately 11 years old. The change is straightforward and poses no risk to test behavior.

Consider using a dynamic date (e.g., date('Y-m-d') or a fixed relative date) in future updates to avoid this value becoming outdated again, but this is not required for the current change.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg added this to the 6.27 milestone Jan 6, 2026
@Crabcyborg
Crabcyborg merged commit 75c546f into master Jan 6, 2026
36 checks passed
@Crabcyborg
Crabcyborg deleted the use_less_old_date_value_in_test_data branch January 6, 2026 15:32
stephywells pushed a commit that referenced this pull request Apr 4, 2026
…est_data

Use less old date value in test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant