Skip to content

Remove some unused private functions#2657

Merged
Crabcyborg merged 1 commit into
masterfrom
remove_some_unused_private_functions
Dec 12, 2025
Merged

Remove some unused private functions#2657
Crabcyborg merged 1 commit into
masterfrom
remove_some_unused_private_functions

Conversation

@Crabcyborg

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Three unused private static helper methods removed from different classes: run_field_migrations() from FrmXMLHelper, get_value_from_entry() from FrmFormAction, and is_plugin_installed() from FrmInstallPlugin. No functional changes or control flow modifications introduced.

Changes

Cohort / File(s) Summary
Unused private method removals
classes/helpers/FrmXMLHelper.php, classes/models/FrmFormAction.php, classes/models/FrmInstallPlugin.php
Removed three unused private static helper methods: run_field_migrations(), get_value_from_entry(), and is_plugin_installed(). No public API or control flow changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • All changes are deletions of unused private static methods with no functional impact
  • No control flow, logic, or dependency changes to evaluate
  • Simple cleanup requiring only verification that removed methods are indeed unused

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, but the title and diff context are sufficient to understand the straightforward refactoring work. Consider adding a brief description explaining why these functions were deemed unused and the impact of their removal.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing unused private functions from three PHP files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove_some_unused_private_functions

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc4edaf and 69c42f8.

📒 Files selected for processing (3)
  • classes/helpers/FrmXMLHelper.php (0 hunks)
  • classes/models/FrmFormAction.php (0 hunks)
  • classes/models/FrmInstallPlugin.php (0 hunks)
💤 Files with no reviewable changes (3)
  • classes/models/FrmInstallPlugin.php
  • classes/helpers/FrmXMLHelper.php
  • classes/models/FrmFormAction.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: Cypress
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg
Crabcyborg merged commit 8a4703b into master Dec 12, 2025
37 of 38 checks passed
@Crabcyborg
Crabcyborg deleted the remove_some_unused_private_functions branch December 12, 2025 21:44
@Crabcyborg Crabcyborg modified the milestones: 6.27, 6.26.1 Dec 15, 2025
stephywells pushed a commit that referenced this pull request Apr 4, 2026
…unctions

Remove some unused private functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant